fix: set anvilSlotsInAnEpoch in e2e_offchain_payment to prevent premature finalization#21398
Closed
AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
Closed
fix: set anvilSlotsInAnEpoch in e2e_offchain_payment to prevent premature finalization#21398AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
Conversation
…ture finalization
AztecBot
force-pushed
the
claudebox/fix-offchain-payment-reorg-test
branch
from
794d44a to
d1c3bc0
Compare
AztecBot
changed the title
Collaborator
|
Closing as duplicate — superseded by a newer attempt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reprocesses an offchain-delivered payment after an L1 reorgtest ine2e_offchain_payment.test.tswas failing withCannot rollback to block 8 as it is before finalized 9.slotsInAnEpoch=1, blocks finalize almost immediately (finalized = latest - 2), so by the time the test callsrollbackTo(block-1)the block is already finalized.anvilSlotsInAnEpoch: 32to the test setup, matching the pattern inepochs_l1_reorgs.parallel.test.ts, so the finalized block lags far enough behind for rollbacks to work.Full analysis: https://gist.github.com/AztecBot/1e9ac04fcafb77b3405ea001de7d1a00