fix(e2e): set anvilSlotsInAnEpoch in offchain payment test to prevent premature finalization#21393
Closed
AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
Closed
fix(e2e): set anvilSlotsInAnEpoch in offchain payment test to prevent premature finalization#21393AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
AztecBot wants to merge 1 commit intomerge-train/fairiesfrom
Conversation
… premature finalization
Collaborator
|
Closing as duplicate — superseded by a newer attempt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
e2e_offchain_paymenttest's reorg test case fails with "Cannot rollback to block 8 as it is before finalized 9" because PR #21156 (Properly compute finalized block) changed Anvil's default--slots-in-an-epochto 1, causing blocks to be finalized almost immediately (finalized = latest - 2).The fix sets
anvilSlotsInAnEpoch: 32in the test's setup, matching the same pattern used byepochs_l1_reorgs.parallel.test.tswhich was updated in #21156.Details
merge-train/fairies— the offchain reception feature (feat: offchain reception #20893) added a test withforceReorg(), while chore: Properly compute finalized block #21156 changed L1 finality behavior. The test's rollback target was already finalized by the time it executed.ClaudeBox log: https://claudebox.work/s/2cc546f52c926894?run=1