fix(e2e): use L2 priority fee in deploy_method same-block test#21373
Merged
PhilWindle merged 2 commits intomerge-train/spartanfrom Mar 11, 2026
Merged
fix(e2e): use L2 priority fee in deploy_method same-block test#21373PhilWindle merged 2 commits intomerge-train/spartanfrom
PhilWindle merged 2 commits intomerge-train/spartanfrom
Conversation
The test used GasFees(1n, 0n) to give the deploy tx higher priority, but DA gas fees are zero in the test environment. Since priority fees are now capped by maxFeesPerGas (PR #21279), min(0, 1) = 0, making both txs have equal priority and the deploy tx no longer guaranteed to be ordered first. Switch to GasFees(0n, 1n) so the L2 priority fee is effective (L2 gas fees are non-zero).
PhilWindle
approved these changes
Mar 11, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
BEGIN_COMMIT_OVERRIDE fix: (A-623) increase committee timeout in scenario smoke test (#21193) feat: orchestrator enqueues via serial queue (#21247) feat: rollup mana limit gas validation (#21219) fix: make e2e HA test more deterministic (#21199) chore: fix chonk_browser lint warning (#21265) chore: deploy SPONSORED_FPC in test networks (#21254) fix: (A-635) e2e bot flake on nonce mismatch (#21288) chore: deflake duplicate attestations and proposals slash tests (#21294) fix(sequencer): fix log when not enough txs (#21297) chore: send env var to pods (#21307) fix: Simulate gas in n tps test. Set min txs per block to 1 (#21312) fix: update dependabot dependencies (#21238) test: run nightly bench of block capacity (#20726) fix: update block_capacity test to use new send() result types (#21345) fix(node): fix index misalignment in findLeavesIndexes (#21327) fix(log): do not log validation error if unregistered handler (#21111) fix: limit parallel blocks in prover to max AVM parallel simulations (#21320) fix: use native sha256 to speed up proving job id generation (#21292) chore: remove v4-devnet-1 (#21044) fix(validator): wait for l1 sync before processing block proposals (#21336) fix(txpool): cap priority fee with max fees when computing priority (#21279) chore: Properly compute finalized block (#21156) fix: remove extra argument in KVArchiverDataStore constructor call (#21361) chore: revert l2 slot time 72 -> 36 on scenario network (#21291) fix(archiver): do not error if proposed block matches checkpointed (#21367) fix(claude): rule to not append echo exit (#21368) chore: reduce severity of errors due to HA node not acquiring signature (#21311) fix: make reqresp batch retry test deterministic (#21322) fix: (A-643) add buffer to maxFeePerBlobGas for gas estimation and fix bump loop truncation (#21323) fix(e2e): use L2 priority fee in deploy_method same-block test (#21373) fix: reqresp flake & add logging (#21334) END_COMMIT_OVERRIDE
AztecBot
added a commit
that referenced
this pull request
Mar 12, 2026
DA gas fees are zero in the test environment, so GasFees(1n, 0n) results in zero effective priority fee after capping. Switch to GasFees(0n, 1n) to use L2 gas priority instead, ensuring the deploy tx is ordered before the public call tx. Cherry-pick of the fix from #21373.
mverzilli
pushed a commit
that referenced
this pull request
Mar 13, 2026
## Summary Fixes flaky `deploy_method.test.ts` failure on `merge-train/spartan` caused by interaction with PR #21279 (priority fee capping). The test used `GasFees(1n, 0n)` to give the deploy tx higher priority, but DA gas fees are zero in the test environment. Since priority fees are now capped by `maxFeesPerGas`, `min(0, 1) = 0` made both txs have equal priority — the deploy tx was no longer guaranteed to be ordered first. Switched to `GasFees(0n, 1n)` so the L2 priority fee is effective (L2 gas fees are non-zero). Full analysis: https://gist.github.com/AztecBot/6ac6f06f68d7507d726c596a67ae350b ## Test plan - All 11 tests in `deploy_method.test.ts` pass locally (ran twice) ClaudeBox log: https://claudebox.work/s/e9857814f97604f8?run=3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky
deploy_method.test.tsfailure onmerge-train/spartancaused by interaction with PR #21279 (priority fee capping).The test used
GasFees(1n, 0n)to give the deploy tx higher priority, but DA gas fees are zero in the test environment. Since priority fees are now capped bymaxFeesPerGas,min(0, 1) = 0made both txs have equal priority — the deploy tx was no longer guaranteed to be ordered first.Switched to
GasFees(0n, 1n)so the L2 priority fee is effective (L2 gas fees are non-zero).Full analysis: https://gist.github.com/AztecBot/6ac6f06f68d7507d726c596a67ae350b
Test plan
deploy_method.test.tspass locally (ran twice)ClaudeBox log: https://claudebox.work/s/e9857814f97604f8?run=3