Skip to content

fix(sequencer): fix log when not enough txs #21297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 1 commit into from
Mar 10, 2026
Merged

fix(sequencer): fix log when not enough txs #21297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions yarn-project/sequencer-client/src/sequencer/checkpoint_proposal_job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,8 +542,7 @@ export class CheckpointProposalJob implements Traceable {

try {
// Wait until we have enough txs to build the block
const minTxs = this.config.minTxsPerBlock;
const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
if (!canStartBuilding) {
this.log.warn(
`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`,
Expand Down Expand Up @@ -665,7 +664,7 @@ export class CheckpointProposalJob implements Traceable {
blockNumber: BlockNumber;
indexWithinCheckpoint: IndexWithinCheckpoint;
buildDeadline: Date | undefined;
}): Promise<{ canStartBuilding: boolean; availableTxs: number }> {
}): Promise<{ canStartBuilding: boolean; availableTxs: number; minTxs: number }> {
const { indexWithinCheckpoint, blockNumber, buildDeadline, forceCreate } = opts;

// We only allow a block with 0 txs in the first block of the checkpoint
Expand All @@ -682,7 +681,7 @@ export class CheckpointProposalJob implements Traceable {
// If we're past deadline, or we have no deadline, give up
const now = this.dateProvider.nowAsDate();
if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
return { canStartBuilding: false, availableTxs: availableTxs };
return { canStartBuilding: false, availableTxs, minTxs };
}

// Wait a bit before checking again
Expand All @@ -695,7 +694,7 @@ export class CheckpointProposalJob implements Traceable {
availableTxs = await this.p2pClient.getPendingTxCount();
}

return { canStartBuilding: true, availableTxs };
return { canStartBuilding: true, availableTxs, minTxs };
}

/**
Expand Down
Loading