feat(p2p): reject and evict txs with insufficient max fee per gas by spalladino · Pull Request #21281 · AztecProtocol/aztec-packages

spalladino · 2026-03-10T01:33:23Z

Summary

Previously, GasTxValidator returned skipped when a tx's maxFeesPerGas was below current block fees, allowing it to wait for lower fees. This changes it to invalid, rejecting the tx outright.
Extracts MaxFeePerGasValidator as a standalone generic validator (like GasLimitsValidator) so it can be used in pool migration alongside full Tx validation.
Adds InsufficientFeePerGasEvictionRule that evicts pending txs after a new block is mined if their maxFeesPerGas no longer meets the block's gas fees.
Adds maxFeesPerGas to TxMetaValidationData so the eviction rule and pool migration validator can access it from metadata.

Caveat: This may evict transactions that would become valid if block fees later drop. A more nuanced approach would define a threshold (e.g. 50% of current fees) and only reject/evict below that. The current approach is simpler and ensures the pool doesn't accumulate low-fee txs unlikely to be mined soon.

🤖 Generated with Claude Code

PhilWindle

Thanks for this.

Could you add tests to tx_pool_v2.test.ts please?

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

spalladino · 2026-03-11T13:44:59Z

yarn-project/end-to-end/src/test-wallet/test_wallet.ts

    private readonly nodeRef: AztecNodeProxy,
  ) {
    super(pxe, nodeRef);
+    this.minFeePadding = 5;


@Thunkar you ok with this change?

Do we need it always or just for this test? (There's a setter)

In general, TestWallet can be altered to fit tests, EmbeddedWallet is the public facing class now!

Do we need it always or just for this test? (There's a setter)

Every test potentially needs it!

AztecBot · 2026-03-12T15:05:50Z

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/fce72367613af837�fce72367613af8378;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/gossip_network_no_cheat.test.ts (165s) (code: 0) group:e2e-p2p-epoch-flakes

AztecBot · 2026-03-12T15:08:10Z

❌ Failed to cherry-pick to v4-next due to conflicts. (🤖) View backport run.

…e per gas (#21281) Cherry-pick of 9e2d79c with conflicts. Conflicts: - yarn-project/end-to-end/src/spartan/block_capacity.test.ts: modify/delete conflict (deleted in v4-next, modified in source)

… gas (#21281)" This reverts commit 9e2d79c.

… gas (#21281)" (#21432) This reverts commit 9e2d79c.

…e per gas (#21281) Cherry-pick of 9e2d79c with conflicts. Conflicts: - yarn-project/end-to-end/src/spartan/block_capacity.test.ts: modify/delete conflict (deleted in v4-next, modified in source)

BEGIN_COMMIT_OVERRIDE feat: add ETHEREUM_HTTP_TIMEOUT_MS env var for viem HTTP transport (#20919) fix(archiver): filter tagged log queries by block number (#21388) fix(node): handle slot zero in getL2ToL1Messages (#21386) feat(sequencer): redistribute checkpoint budget evenly across remaining blocks (#21378) fix: fall back to package.json for CLI version detection (#21382) chore: Removed multiplier config (#21412) chore: Removed default snapshot url config (#21413) chore: Read tx filestores from network config (#21416) fix(node): check world state against requested block hash (#21385) feat(p2p): use l2 priority fee only for tx priority (#21420) feat(p2p): reject and evict txs with insufficient max fee per gas (#21281) revert "feat(p2p): reject and evict txs with insufficient max fee per gas (#21281)" (#21432) chore: Reduce log spam (#21436) fix(tx): reject txs with invalid setup when unprotecting (#21224) fix: orchestrator enqueue yield (#21286) chore(builder): check archive tree next leaf index during block building (#21457) fix: scenario deployment (#21428) chore: add claude skill to read network-logs (#21495) chore: update claude network-logs skill (#21523) feat(rpc): add package version to RPC response headers (#21526) chore(prover): silence "epoch to prove" debug logs (#21527) chore(sequencer): do not log blob data (#21530) fix: dependabot alerts (#21531) docs(p2p): nicer READMEs (#21456) fix(archiver): guard getL1ToL2Messages against incomplete message sync (#21494) fix(sequencer): await syncing proposed block to archiver (#21554) feat(ethereum): check VK tree root and protocol contracts hash in rollup compatibility (#21537) fix: marking peer as dumb on failed responses (#21316) fix(kv-store): make LMDB clear and drop operations atomic across sub-databases (#21539) feat(world-state): add blockHash verification to syncImmediate (#21556) chore(monitor): print out l2 fees components (#21559) chore: rm faucet (#21538) chore: remove old merkle trees (#21577) feat: Implement commit all and revert all for world state checkpoints (#21532) chore: skip flaky browser acir tests in CI (#21596) fix: Better detection for epoch prune (#21478) chore: logging (#21604) fix: Don't update state if we failed to execute sufficient transactions (#21443) END_COMMIT_OVERRIDE

PhilWindle approved these changes Mar 10, 2026

View reviewed changes

spalladino added the backport-later label Mar 10, 2026

spalladino and others added 2 commits March 10, 2026 20:46

feat(p2p): reject and evict txs with insufficient max fee per gas

af3d7c1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

test(p2p): add tx pool tests for max fee per gas validation and eviction

0614fbc

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

spalladino force-pushed the palla/max-fee-per-gas-validation branch from 6f36358 to 0614fbc Compare March 10, 2026 20:52

spalladino enabled auto-merge (squash) March 11, 2026 01:08

ludamad removed the backport-later label Mar 11, 2026

Merge branch 'merge-train/spartan' into palla/max-fee-per-gas-validation

5591717

spalladino added the backport-to-v4-next label Mar 11, 2026

spalladino commented Mar 11, 2026

View reviewed changes

spalladino added the ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure label Mar 11, 2026

update test wallet min fee padding to 10x

26534ab

spalladino force-pushed the palla/max-fee-per-gas-validation branch from 5a84ee8 to 26534ab Compare March 11, 2026 17:30

spalladino added 2 commits March 12, 2026 14:04

fix: use next block gas fees rather than last block for validation

8391e71

fix gossip_network_no_cheat test

b13804b

spalladino merged commit 9e2d79c into merge-train/spartan Mar 12, 2026
10 checks passed

spalladino deleted the palla/max-fee-per-gas-validation branch March 12, 2026 15:06

AztecBot mentioned this pull request Mar 12, 2026

feat: merge-train/spartan #21407

Merged

AztecBot mentioned this pull request Mar 12, 2026

feat(p2p): reject and evict txs with insufficient max fee per gas (backport #21281) #21431

Closed

spalladino added a commit that referenced this pull request Mar 12, 2026

revert "feat(p2p): reject and evict txs with insufficient max fee per…

f630821

… gas (#21281)" This reverts commit 9e2d79c.

spalladino added a commit that referenced this pull request Mar 12, 2026

revert "feat(p2p): reject and evict txs with insufficient max fee per…

eff0efa

… gas (#21281)" (#21432) This reverts commit 9e2d79c.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(p2p): reject and evict txs with insufficient max fee per gas#21281

feat(p2p): reject and evict txs with insufficient max fee per gas#21281
spalladino merged 6 commits intomerge-train/spartanfrom
palla/max-fee-per-gas-validation

spalladino commented Mar 10, 2026

Uh oh!

PhilWindle left a comment

Uh oh!

spalladino Mar 11, 2026

Uh oh!

Thunkar Mar 11, 2026 •

edited

Loading

Uh oh!

spalladino Mar 11, 2026

Uh oh!

AztecBot commented Mar 12, 2026

Uh oh!

Uh oh!

AztecBot commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

spalladino commented Mar 10, 2026

Summary

Uh oh!

PhilWindle left a comment

Choose a reason for hiding this comment

Uh oh!

spalladino Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Thunkar Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spalladino Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

AztecBot commented Mar 12, 2026

Flakey Tests

Uh oh!

Uh oh!

AztecBot commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Thunkar Mar 11, 2026 •

edited

Loading