fix: add barretenberg-rs and iOS/Android targets to Makefile#21204
Merged
johnathan79717 merged 1 commit intonextfrom Mar 6, 2026
Merged
fix: add barretenberg-rs and iOS/Android targets to Makefile#21204johnathan79717 merged 1 commit intonextfrom
johnathan79717 merged 1 commit intonextfrom
Conversation
notnotraju
approved these changes
Mar 6, 2026
c69829b to
7f9ff76
Compare
7f9ff76 to
3bd2067
Compare
Add bb-rs and bb-rs-tests targets so the Rust FFI crate is built and link-tested as part of fast and full CI. Add iOS and Android cross-compile targets (bb-cpp-cross-arm64-ios, bb-cpp-cross-arm64-ios-sim, bb-cpp-cross-arm64-android, bb-cpp-cross-x86_64-android) wired into bb-cpp-cross for releases.
3bd2067 to
033589e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
bb-rsandbb-rs-teststargets to the root Makefile so the Rust FFI crate is built and link-tested as part offastandfullCI (not onlyci-barretenberg-full).Also adds iOS and Android cross-compile targets (
bb-cpp-cross-arm64-ios,bb-cpp-cross-arm64-ios-sim,bb-cpp-cross-arm64-android,bb-cpp-cross-x86_64-android) to the Makefile, wired intobb-cpp-crossso they get built duringrelease. These were previously only built via the legacybuild_with_makefilepath in bootstrap.sh.This would have caught the libc++/libstdc++ mismatch (fixed in #21203) that was introduced when the Zig preset became the default.