Skip to content

fix(p2p): report most severe failure in runValidations #21185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 1 commit into from
Mar 5, 2026
Merged

fix(p2p): report most severe failure in runValidations #21185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions yarn-project/p2p/src/services/libp2p/libp2p_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { EpochCacheInterface } from '@aztec/epoch-cache';
import { BlockNumber, type SlotNumber } from '@aztec/foundation/branded-types';
import { maxBy } from '@aztec/foundation/collection';
import { Fr } from '@aztec/foundation/curves/bn254';
import { type Logger, createLibp2pComponentLogger, createLogger } from '@aztec/foundation/log';
import { RunningPromise } from '@aztec/foundation/running-promise';
Expand All @@ -19,6 +20,7 @@ import {
P2PMessage,
type ValidationResult as P2PValidationResult,
PeerErrorSeverity,
PeerErrorSeverityByHarshness,
TopicType,
createTopicString,
getTopicsForConfig,
Expand Down Expand Up @@ -1662,8 +1664,10 @@ export class LibP2PService extends WithTracer implements P2PService {

// A promise that resolves when all validations have been run
const allValidations = await Promise.all(validationPromises);
const failed = allValidations.find(x => !x.isValid);
if (failed) {
const failures = allValidations.filter(x => !x.isValid);
if (failures.length > 0) {
// Pick the most severe failure (lowest tolerance = harshest penalty)
const failed = maxBy(failures, f => PeerErrorSeverityByHarshness.indexOf(f.severity))!;
return {
allPassed: false,
failure: {
Expand Down
7 changes: 7 additions & 0 deletions yarn-project/stdlib/src/p2p/peer_error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,10 @@ export enum PeerErrorSeverity {
*/
HighToleranceError = 'HighToleranceError',
}

/** Severities ordered from mildest to harshest. */
export const PeerErrorSeverityByHarshness = [
PeerErrorSeverity.HighToleranceError,
PeerErrorSeverity.MidToleranceError,
PeerErrorSeverity.LowToleranceError,
] as const;
Loading