Skip to content

chore: remove stale aes comments #21133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nventuro merged 1 commit into from
Mar 4, 2026
Merged

chore: remove stale aes comments #21133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions noir-projects/aztec-nr/aztec/src/messages/encryption/aes128.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,6 @@ impl MessageEncryption for AES128 {
// Derive ECDH shared secret with recipient using a fresh ephemeral keypair.
let (eph_sk, eph_pk) = generate_positive_ephemeral_key_pair();

// (not to be confused with the tagging shared secret) TODO (#17158): Currently we unwrap the Option returned
// by derive_ecdh_shared_secret. We need to handle the case where the ephemeral public key is invalid to
// prevent potential DoS vectors.
let ciphertext_shared_secret = derive_ecdh_shared_secret(
eph_sk,
recipient
Expand All @@ -269,7 +266,6 @@ impl MessageEncryption for AES128 {
)
.inner,
);
// TODO: also use this shared secret for deriving note randomness.

// AES128-CBC encrypt the plaintext bytes.
// It is safe to call the `unsafe` function here, because we know the `shared_secret` was derived using an
Expand Down
Loading