Skip to content

fix(log): do not log validation error if unregistered handler #21111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilWindle merged 1 commit into from
Mar 11, 2026
Merged

fix(log): do not log validation error if unregistered handler #21111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions yarn-project/p2p/src/services/libp2p/libp2p_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,11 @@ export class LibP2PService extends WithTracer implements P2PService {
this.gossipSubEventHandler = this.handleGossipSubEvent.bind(this);

this.blockReceivedCallback = async (block: BlockProposal): Promise<boolean> => {
this.logger.debug(
`Handler not yet registered: Block received callback not set. Received block for slot ${block.slotNumber} from peer.`,
this.logger.warn(
`Handler for block received not yet registered on P2P service. Received block ${block.blockNumber} for slot ${block.slotNumber} from peer.`,
{ p2pMessageIdentifier: await block.p2pMessageLoggingIdentifier() },
);
return false;
return true;
};

this.checkpointReceivedCallback = (
Expand Down
Loading