Skip to content

chore: better parallelisation of translator wire instantiation #21100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suyash67 merged 4 commits into from
Mar 21, 2026
Merged

chore: better parallelisation of translator wire instantiation #21100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72390df
better multi threading in copying wires.
suyash67 Mar 4, 2026
33ad97f
rm closed issue todo.
suyash67 Mar 4, 2026
5c1e7fb
rm closed issue.
suyash67 Mar 4, 2026
22f920e
rm old comment.
suyash67 Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions barretenberg/cpp/src/barretenberg/translator_vm/translator_circuit_builder.fuzzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
extern "C" int LLVMFuzzerTestOneInput(const unsigned char* data, size_t size)
{
// Parse the queue and challenges
// TODO(https://github.com/AztecProtocol/barretenberg/issues/869): composer generates the initial challenge through
// FS, so we have to do that, too
auto parsing_result = parse_and_construct_opqueue(data, size);
if (!parsing_result.has_value()) {
return 0;
Expand Down
25 changes: 11 additions & 14 deletions barretenberg/cpp/src/barretenberg/translator_vm/translator_proving_key.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include "barretenberg/common/assert.hpp"
#include "barretenberg/translator_vm/translator_flavor.hpp"
namespace bb {
// TODO(https://github.com/AztecProtocol/barretenberg/issues/1317)
class TranslatorProvingKey {
public:
using Flavor = TranslatorFlavor;
Expand Down Expand Up @@ -54,20 +53,18 @@ class TranslatorProvingKey {

proving_key = std::make_shared<ProvingKey>();
auto wires = proving_key->polynomials.get_wires();
for (auto [wire_poly_, wire_] : zip_view(wires, circuit.wires)) {
auto& wire_poly = wire_poly_;
const auto& wire = wire_;
// TODO(https://github.com/AztecProtocol/barretenberg/issues/1383)
parallel_for_range(circuit.num_gates(), [&](size_t start, size_t end) {
for (size_t i = start; i < end; i++) {
if (i >= wire_poly.start_index() && i < wire_poly.end_index()) {
wire_poly.at(i) = circuit.get_variable(wire[i]);
} else {
BB_ASSERT_EQ(circuit.get_variable(wire[i]), 0);
}
// Distribute wires across threads (one task per wire) rather than multithreading within each wire.
parallel_for(wires.size(), [&](size_t wire_idx) {
auto& wire_poly = wires[wire_idx];
const auto& wire = circuit.wires[wire_idx];
for (size_t i = 0; i < circuit.num_gates(); i++) {
if (i >= wire_poly.start_index() && i < wire_poly.end_index()) {
wire_poly.at(i) = circuit.get_variable(wire[i]);
} else {
BB_ASSERT_EQ(circuit.get_variable(wire[i]), 0);
}
});
}
}
});

// Iterate over all circuit wire polynomials, except the ones representing the op queue, and add random values
// at the end.
Expand Down
Loading