Skip to content

fix: resolve flaky p2p_client test race condition on ARM64 #21088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilWindle merged 1 commit into from
Mar 4, 2026
Merged

fix: resolve flaky p2p_client test race condition on ARM64 #21088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions yarn-project/p2p/src/client/p2p_client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,12 +381,17 @@ describe('P2P Client', () => {

it('triggers tx collection for missing txs from mined blocks', async () => {
await client.start();
// Drain any initial background sync that processes the initial blocks (1-100),
// which may call startCollecting depending on timing.
await client.sync();

const block = await L2Block.random(BlockNumber(101), { txsPerBlock: 3 });
// Compute the block hash since it gets cached when the p2p client logs it
await block.hash();

txPool.hasTxs.mockResolvedValue([true, false, true]);
blockSource.addProposedBlocks([block]);
txCollection.startCollecting.mockClear();
await client.sync();

expect(txCollection.startCollecting).toHaveBeenCalledTimes(1);
Expand Down
Loading