fix: update MAX_EVENT_SERIALIZATION_LENGTH and re-enable TXE tests in CI (backport #21020)#21027
Merged
ludamad merged 1 commit intobackport-to-v4-stagingfrom Mar 3, 2026
Merged
Conversation
… CI (#21020) ## Summary Two fixes: ### 1. Fix `MAX_EVENT_SERIALIZATION_LENGTH` mismatch (fixes backport CI failure) #20840 changed `MAX_EVENT_LEN` from 12 to 10 in `yarn-project/txe/src/rpc_translator.ts` but forgot to update the corresponding Noir constant `MAX_EVENT_SERIALIZATION_LENGTH` in `txe_oracles.nr`. This caused the TXE oracle to return `10 * 5 = 50` fields while the Noir oracle declaration expected `12 * 5 = 60` fields, crashing the `emit_and_discover_event` test. ### 2. Re-enable TXE-dependent noir tests in CI Since Feb 24, all TXE-dependent noir tests (`noir-projects-txe-tests`) have been silently disabled in CI. The `build_and_test` function in `bootstrap.sh` has a guard `if [ -z "${1:-}" ]` that only runs TXE tests when no argument is passed, but CI always calls `build_and_test fast` or `build_and_test full`. This means the TXE tests only ran in local dev (no args) but never in CI. This fix removes the conditional so TXE tests run in all CI modes (ci-fast, ci-full, ci-full-no-test-cache). [ClaudeBox log](http://ci.aztec-labs.com/7a1d8c5993720a62-5)
ludamad
approved these changes
Mar 3, 2026
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21020 to v4.
Cherry-pick applied cleanly — no conflicts.
Summary
Two fixes:
1. Fix
MAX_EVENT_SERIALIZATION_LENGTHmismatchPR #20840 changed
MAX_EVENT_LENfrom 12 to 10 inyarn-project/txe/src/rpc_translator.tsbut forgot to update the corresponding Noir constantMAX_EVENT_SERIALIZATION_LENGTHintxe_oracles.nr. This caused the TXE oracle to return10 * 5 = 50fields while the Noir oracle declaration expected12 * 5 = 60fields, crashing theemit_and_discover_eventtest.2. Re-enable TXE-dependent noir tests in CI
The
build_and_testfunction inbootstrap.shhad a guard that only ran TXE tests when no argument was passed, but CI always callsbuild_and_test fastorbuild_and_test full. This fix removes the conditional so TXE tests run in all CI modes.ClaudeBox log: http://ci.aztec-labs.com/ed670f8e16fb711b-1