chore(checkpoints): add more cheap checkpoint validations#21006
Closed
spalladino wants to merge 1 commit intopalla/update-block-build-limitsfrom
Closed
chore(checkpoints): add more cheap checkpoint validations#21006spalladino wants to merge 1 commit intopalla/update-block-build-limitsfrom
spalladino wants to merge 1 commit intopalla/update-block-build-limitsfrom
Conversation
spalladino
force-pushed
the
palla/extra-checkpoint-validations
branch
from
1fff346 to
779a9d7
Compare
spalladino
force-pushed
the
palla/update-block-build-limits
branch
from
b0c9e08 to
f3b702f
Compare
spalladino
requested review from
IlyasRidhuan,
dbanks12,
fcarreiro,
jeanmon and
sirasistant
as code owners
spalladino
removed request for
IlyasRidhuan,
dbanks12,
fcarreiro,
jeanmon and
sirasistant
spalladino
force-pushed
the
palla/extra-checkpoint-validations
branch
from
779a9d7 to
65d1882
Compare
Contributor
Author
|
Closing in favor of pushing it as another commit in #21016 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more validations to the
validateCheckpointmethod, currently run right before sending a proposal and signing an attestation. Also wires this validation to right before pushing a checkpoint into the store.