Skip to content

fix: increase minFeePadding in e2e_bot bridge resume tests and harden GasFees.mul() #20962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 3 commits into from
Feb 27, 2026
Merged

fix: increase minFeePadding in e2e_bot bridge resume tests and harden GasFees.mul() #20962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42a6646
fix: increase minFeePadding in e2e_bot bridge resume tests and harden…
AztecBot Feb 27, 2026
4199876
fix: increase minFeePadding in e2e_bot bridge resume tests and harden…
AztecBot Feb 27, 2026
f570f6f
Delete yarn.lock
ludamad Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions yarn-project/end-to-end/src/e2e_bot.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,9 @@ describe('e2e_bot', () => {
// TODO: this should be taken from the `setup` call above
l1Mnemonic: new SecretValue('test test test test test test test test test test test junk'),
flushSetupTransactions: true,
// Increase fee headroom to handle fee volatility from rapid block building in tests
minFeePadding: 9,
// Increase fee headroom to handle fee volatility from rapid block building in tests.
// Fees can escalate >10x due to blocks built by earlier tests and bridge operations.
minFeePadding: 99,
};

{
Expand Down Expand Up @@ -174,8 +175,10 @@ describe('e2e_bot', () => {
// TODO: this should be taken from the `setup` call above
l1Mnemonic: new SecretValue('test test test test test test test test test test test junk'),
flushSetupTransactions: true,
// Increase fee headroom to handle fee volatility from rapid block building in tests
minFeePadding: 9,
// Increase fee headroom to handle fee volatility from rapid block building in tests.
// This test is especially susceptible because changing salt triggers a new bridge claim,
// adding more block building on top of what earlier tests already produced.
minFeePadding: 99,
};

{
Expand Down
8 changes: 7 additions & 1 deletion yarn-project/stdlib/src/gas/gas_fees.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,14 @@ export class GasFees {
return this.clone();
} else if (typeof scalar === 'bigint') {
return new GasFees(this.feePerDaGas * scalar, this.feePerL2Gas * scalar);
} else if (Number.isInteger(scalar)) {
const s = BigInt(scalar);
return new GasFees(this.feePerDaGas * s, this.feePerL2Gas * s);
} else {
return new GasFees(Number(this.feePerDaGas) * scalar, Number(this.feePerL2Gas) * scalar);
return new GasFees(
BigInt(Math.ceil(Number(this.feePerDaGas) * scalar)),
BigInt(Math.ceil(Number(this.feePerL2Gas) * scalar)),
);
}
}

Expand Down
Loading