Skip to content

chore: remove unused prover-node dep #20955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilWindle merged 1 commit into from
Feb 27, 2026
Merged

chore: remove unused prover-node dep #20955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions yarn-project/prover-node/src/factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import {
getPublisherConfigFromProverConfig,
} from '@aztec/sequencer-client';
import type {
AztecNode,
ITxProvider,
ProverConfig,
ProvingJobBroker,
Expand All @@ -38,7 +37,6 @@ import { ProverPublisherFactory } from './prover-publisher-factory.js';
export type ProverNodeDeps = {
telemetry?: TelemetryClient;
log?: Logger;
aztecNodeTxProvider?: Pick<AztecNode, 'getTxsByHash'>;
archiver: Archiver;
publisherFactory?: ProverPublisherFactory;
broker?: ProvingJobBroker;
Expand Down Expand Up @@ -128,9 +126,6 @@ export async function createProverNode(
telemetry,
});

// TODO(#20393): Check that the tx collection node sources are properly injected
// See aztecNodeTxProvider

const proverNodeConfig = {
...pick(
config,
Expand Down
9 changes: 9 additions & 0 deletions yarn-project/prover-node/src/prover-node.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,15 @@ describe('prover-node', () => {
expect(proverNode.totalJobCount).toEqual(0);
});

it('gathers txs via the p2p client tx provider', async () => {
await proverNode.handleEpochReadyToProve(EpochNumber.fromBigInt(10n));
// The prover node must route tx gathering through the shared p2p client's tx provider
expect(p2p.getTxProvider).toHaveBeenCalled();
// One call per block across all checkpoints in the epoch
const totalBlocks = checkpoints.flatMap(c => c.blocks).length;
expect(txProvider.getTxsForBlock).toHaveBeenCalledTimes(totalBlocks);
});

it('does not start a proof if there is a tx missing from coordinator', async () => {
txProvider.getTxsForBlock.mockResolvedValue({ missingTxs: [TxHash.random()], txs: [] });
await proverNode.handleEpochReadyToProve(EpochNumber.fromBigInt(10n));
Expand Down
Loading