Conversation
Fix logging eth addresses <img width="774" height="532" alt="image" src="https://github.com/user-attachments/assets/0dbd1587-949a-4cf2-a0b0-fca80ac13454" />
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
… and remove P2PClientType enum (#20848)
#20942) ## Summary Closes A-596 - Anchors `SLASH_GRACE_PERIOD_L2_SLOTS` to the `CanonicalRollupUpdated` event emitted by the Registry when the rollup becomes canonical, instead of comparing against genesis slot 0 - Adds `getCanonicalRollupRegistrationTimestamp()` to `RegistryContract` to query the registration event timestamp - Computes and caches the canonical rollup registration L2 slot in the slasher factory, threading it through to the `SlashOffensesCollector` where the grace period comparison now uses `offenseSlot < registeredSlot + gracePeriodSlots` ## Motivation The rollup can be deployed weeks/months before becoming canonical (registered via `addRollup()`). By upgrade time, the current slot is far past any "slot from genesis" value, making the grace period ineffective. Now operators just set a duration (e.g. 3600 slots = 3 days) and the system anchors it to the actual upgrade time automatically. ## Test plan - Unit tests updated and passing for `SlashOffensesCollector`, `EmpireSlasherClient`, and `TallySlasherClient` - Grace period test verifies offenses within `registeredSlot + gracePeriod` are skipped and offenses after are not
alexghr
approved these changes
Feb 27, 2026
aminsammara
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: logging of class instances (#20807)
chore: deps (#20910)
refactor(aztec-node): skip unnecessary subsystems in prover-only mode and remove P2PClientType enum (#20848)
chore: Configs for next-net, testnet etc (#20803)
feat(slasher): make slash grace period relative to rollup upgrade time (#20942)
docs: add docs on state vars docs re packing in structs (#20747)
chore: remove unused prover-node dep (#20955)
END_COMMIT_OVERRIDE