Skip to content

fix(cli): expand scientific notation in network config generator #20928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aminsammara wants to merge 1 commit into from
Closed

fix(cli): expand scientific notation in network config generator #20928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions yarn-project/cli/scripts/generate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,44 @@ HEADER
# Get all network keys from the networks section
networks=$(yq -o json '.networks | keys' spartan/environments/network-defaults.yml | jq -r '.[]')

# format_value: Converts a YAML value string to a TypeScript literal.
# Handles scientific notation like "200000e18" by expanding to full integer,
# since BigInt() cannot parse scientific notation strings.
format_value() {
local val="$1"
# Expand integer scientific notation (e.g., 200000e18 -> 200000000000000000000000)
if [[ "$val" =~ ^[0-9]+e[0-9]+$ ]]; then
python3 -c "
import re, sys
m = re.match(r'^(\d+)e(\d+)$', sys.argv[1])
print(int(m.group(1)) * (10 ** int(m.group(2))))
" "$val"
else
echo "$val"
fi
}

for network in $networks; do
echo "export const ${network}Config = {" >> yarn-project/cli/src/config/generated/networks.ts
yq -o json "explode(.) | .networks.$network // {}" spartan/environments/network-defaults.yml | \
jq -r "to_entries | .[] | \" \\(.key): \\(.value | if type == \"string\" then \"'\\(.)'\" else . end),\"" \
>> yarn-project/cli/src/config/generated/networks.ts

# Use yq to iterate entries, converting values to strings to preserve
# the original YAML text (avoids float64 precision loss for large numbers).
while IFS= read -r line; do
key=$(echo "$line" | cut -d':' -f1 | xargs)
raw_value=$(echo "$line" | cut -d':' -f2- | xargs)

formatted=$(format_value "$raw_value")

# Determine TypeScript formatting: strings get quotes, booleans/numbers are bare
if [[ "$formatted" == "true" || "$formatted" == "false" ]]; then
echo " $key: $formatted," >> yarn-project/cli/src/config/generated/networks.ts
elif [[ "$formatted" =~ ^-?[0-9]*\.?[0-9]+$ ]]; then
echo " $key: $formatted," >> yarn-project/cli/src/config/generated/networks.ts
else
echo " $key: '$formatted'," >> yarn-project/cli/src/config/generated/networks.ts
fi
done < <(yq "explode(.) | .networks.$network | to_entries | .[] | .key + \": \" + (.value | . tag = \"!!str\")" spartan/environments/network-defaults.yml)

echo "} as const;" >> yarn-project/cli/src/config/generated/networks.ts
echo "" >> yarn-project/cli/src/config/generated/networks.ts
done
Expand Down
Loading