Skip to content

feat!: make unused msg disco fns private #20831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nventuro merged 4 commits into from
Feb 27, 2026
Merged

feat!: make unused msg disco fns private #20831

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cd33b4
feat!: make unused msg disco fns private
nventuro Feb 24, 2026
eab8bd2
making the thing compile
benesjan Feb 26, 2026
6df264d
fmt fixes
benesjan Feb 26, 2026
315141e
Merge branch 'merge-train/fairies' into nico/f-358-make-msg-discovery…
nventuro Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
making the thing compile
  • Loading branch information
@benesjan
benesjan committed Feb 26, 2026
commit eab8bd2a93945a1224874b49ec15036e8c9410c0
6 changes: 3 additions & 3 deletions noir-projects/aztec-nr/aztec/src/messages/discovery/mod.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::protocol::{address::AztecAddress, logging::{debug_log, debug_log_form
pub(crate) mod nonce_discovery;
pub(crate) mod partial_notes;
pub(crate) mod private_events;
pub(crate) mod private_notes;
pub mod private_notes;
pub mod process_message;

use crate::{
Expand All @@ -21,12 +21,12 @@ use crate::{

pub struct NoteHashAndNullifier {
/// The result of [`crate::note::note_interface::NoteHash::compute_note_hash`].
pub(crate) note_hash: Field,
pub note_hash: Field,
/// The result of [`crate::note::note_interface::NoteHash::compute_nullifier_unconstrained`].
///
/// This value is unconstrained as all of message discovery is unconstrained. This is `None` if the nullifier

@benesjan benesjan Feb 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change made the code un-compilable because the fields are directly used by generate_contract_library_method_compute_note_hash_and_nullifier.

Reverted this change as it makes sense to tackle in a followup.

/// cannot be computed (e.g., because the nullifier hiding key is not available).
pub(crate) inner_nullifier: Option<Field>,
pub inner_nullifier: Option<Field>,
}

/// A contract's way of computing note hashes and nullifiers.
Expand Down
2 changes: 1 addition & 1 deletion noir-projects/aztec-nr/aztec/src/messages/discovery/private_notes.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ pub(crate) unconstrained fn process_private_note_msg<Env>(

/// Attempts discovery of a note given information about its contents and the transaction in which it is suspected the
/// note was created.
pub(crate) unconstrained fn attempt_note_discovery<Env>(
pub unconstrained fn attempt_note_discovery<Env>(
contract_address: AztecAddress,
tx_hash: Field,
unique_note_hashes_in_tx: BoundedVec<Field, MAX_NOTE_HASHES_PER_TX>,
Expand Down
Loading