Skip to content

fix: ECDSA tests in acir_tests don't fail anymore #20689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
federicobarbacovi merged 1 commit into from
Feb 19, 2026
Merged

fix: ECDSA tests in acir_tests don't fail anymore #20689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions barretenberg/acir_tests/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,6 @@ function build {
rm -rf acir_tests/{regression_5045,regression_7744}
# The following test fails because it uses CallData/ReturnData with UltraBuilder, which is not supported
rm -rf acir_tests/{regression_7612,regression_7143,databus_composite_calldata,databus_two_calldata_simple,databus_two_calldata,databus}
# Mark tests that are expected to fail with a failing_ prefix.
# bb_prove.sh will expect these to fail and error if they suddenly pass.
for t in ecdsa_secp256k1_invalid_inputs; do
mv acir_tests/$t acir_tests/failing_$t
sed -i "s/^name = \"$t\"/name = \"failing_$t\"/" acir_tests/failing_$t/Nargo.toml
done
# Merge the internal test programs with the acir tests.
cp -R ./internal_test_programs/* acir_tests

Expand Down
Loading