Merged
Conversation
deffrian
force-pushed
the
nikita/n-tps-zero-metrics
branch
from
d4264ee to
a04ef40
Compare
deffrian
force-pushed
the
nikita/n-tps-zero-metrics
branch
2 times, most recently
from
ac433fa to
b9903c5
Compare
deffrian
added
the
ci-network-bench
AztecBot
removed
the
ci-network-bench
deffrian
added
the
ci-network-bench
AztecBot
removed
the
ci-network-bench
deffrian
force-pushed
the
nikita/n-tps-zero-metrics
branch
from
29b8e0d to
cdbe63b
Compare
deffrian
added
the
ci-network-bench
AztecBot
removed
the
ci-network-bench
deffrian
added
the
ci-network-bench
AztecBot
removed
the
ci-network-bench
mralj
approved these changes
Feb 23, 2026
Contributor
mralj
left a comment
mralj
left a comment
There was a problem hiding this comment.
Pre-approving, I have only small nitpicks about naming
| } | ||
| } | ||
|
|
||
| public objectAdded(key: bigint | string): void { |
Contributor
There was a problem hiding this comment.
I don't like naming of this - it's to vague
| this.txAddedTimestamp.set(key, Date.now()); | ||
| } | ||
|
|
||
| public objectRemoved(key: bigint | string): void { |
Contributor
There was a problem hiding this comment.
Similar to above, naming is too vague
deffrian
force-pushed
the
nikita/n-tps-zero-metrics
branch
from
ba1a67b to
7aaf82a
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
BEGIN_COMMIT_OVERRIDE fix: track last seen nonce in case of stale fallback L1 RPC node (#20855) feat: Validate num txs in block proposals (#20850) fix(archiver): enforce checkpoint boundary on rollbackTo (#20908) fix: tps zero metrics (#20656) fix: handle scientific notation in bigintConfigHelper (#20929) feat(aztec): node enters standby mode on genesis root mismatch (#20938) fix: logging of class instances (#20807) feat(slasher): make slash grace period relative to rollup upgrade time (#20942) chore: add script to find PRs to backport (#20956) chore: remove unused prover-node dep (#20955) fix: increase minFeePadding in e2e_bot bridge resume tests and harden GasFees.mul() (#20962) feat(sequencer): (A-526) rotate publishers when send fails (#20888) chore: (A-554) bump reth version 1.6.0 -> 1.11.1 for eth devnet (#20889) chore: metric on how many epochs validator has been on committee (#20967) fix: set wallet minFeePadding in BotFactory constructor (#20992) chore: deflake epoch invalidate block test (#21001) chore(sequencer): e2e tests for invalid signature recovery in checkpoint attestations (#20971) chore: deflake duplicate proposals and attestations (#20990) chore: deflake epochs mbps test (#21003) feat: reenable function selectors in txPublicSetupAllowList (#20909) fix: limit offenses when voting in tally slashing mode by slashMaxPayloadSize (#20683) fix(spartan): wire SEQ_L1_PUBLISHING_TIME_ALLOWANCE_IN_SLOT env var (#21017) END_COMMIT_OVERRIDE
johnathan79717
pushed a commit
that referenced
this pull request
Mar 4, 2026
Ref: A-493 - Split `peerCount` metric into total connections and healthy connections - Fixed memory leak in peer manager: `peerConnectedAt` map entries are now deleted after recording connection duration - Fixed mined-delay tracking for `TxPoolV2` - Added attestation pool instrumentation - Renamed metrics/groups - Other zero metric fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: A-493
Updated dashboard:
https://aztecprotocol.github.io/benchmark-page-data/bench/?branch=pr-20656
peerCountmetric into total connections and healthy connectionspeerConnectedAtmap entries are now deleted after recording connection durationTxPoolV2