fix!: Tx overhead and private emission L2 gas based on simulation time#20648
Merged
fix!: Tx overhead and private emission L2 gas based on simulation time#20648
Conversation
sirasistant
requested review from
IlyasRidhuan,
LeilaWang,
dbanks12,
fcarreiro and
jeanmon
as code owners
sirasistant
removed request for
IlyasRidhuan,
LeilaWang,
dbanks12,
fcarreiro and
jeanmon
dbanks12
reviewed
Feb 18, 2026
noir-projects/noir-protocol-circuits/crates/types/src/constants.nr
Outdated
Show resolved
Hide resolved
LeilaWang
reviewed
Feb 18, 2026
sirasistant
changed the title
sirasistant
changed the title
LeilaWang
reviewed
Feb 20, 2026
noir-projects/noir-protocol-circuits/crates/types/src/constants.nr
Outdated
Show resolved
Hide resolved
AztecBot
force-pushed
the
arv/tx_overhead_as_base_gas
branch
from
d793918 to
8bb81ab
Compare
This PR: - Splits AVM_MAX_PROCESSABLE_GAS (6M) from MAX_PROCESSABLE_GAS (6M+PUBLIC_TX_OVERHEAD) - Splits Public tx overhead and private tx overhead - Plugs in numbers from simulation metrics to tx overheads - Plugs in numbers from simulation metrics to side effects - TODO: Figure out contract class logs: we are having trouble measuring them.
AztecBot
force-pushed
the
arv/tx_overhead_as_base_gas
branch
from
8bb81ab to
bf1232b
Compare
Collaborator
|
❌ Failed to cherry-pick to |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
#20648) This PR: - Splits AVM_MAX_PROCESSABLE_GAS (6M) from MAX_PROCESSABLE_GAS (6M+PUBLIC_TX_OVERHEAD) - Splits Public tx overhead and private tx overhead - Plugs in numbers from simulation metrics to tx overheads - Plugs in numbers from simulation metrics to side effects - TODO: Figure out contract class logs: we are having trouble measuring them.
This was referenced Feb 20, 2026
alexghr
pushed a commit
that referenced
this pull request
Feb 27, 2026
Backports: - #20712 - #20720 Excluded due to VK changes: - #20648 Co-authored-by: mverzilli <651693+mverzilli@users.noreply.github.com> Co-authored-by: sirasistant <5372114+sirasistant@users.noreply.github.com> Co-authored-by: thunkar <gregojquiros@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: