feat: testing private events from Aztec.nr by benesjan · Pull Request #20640 · AztecProtocol/aztec-packages

benesjan · 2026-02-18T14:11:33Z

Note: We will probably want to merge Serialize and Deserialize traits before merging this as it would make the diff smaller - waiting for response from Mitch to see whether it's a good time to do that change.

Closes https://linear.app/aztec-labs/issue/F-300/feature-access-events-in-aztecnr-tests

benesjan · 2026-02-18T14:11:51Z

feat: testing private events from Aztec.nr #20640 👈 (View in Graphite)
fix(txe): committing after txs #20714
merge-train/fairies

This stack of pull requests is managed by Graphite. Learn more about stacking.

noir-projects/noir-protocol-circuits/crates/serde/src/serialization.nr

noir-projects/aztec-nr/aztec/src/macros/utils.nr

noir-projects/aztec-nr/aztec/src/test/helpers/test_environment/test/events.nr

benesjan · 2026-02-26T06:00:39Z

@nchamo LMK if you would not feel comfortable enough yet to review this. Can re-assing if that's the case.

nchamo

Great improvement!

noir-projects/aztec-nr/aztec/src/test/helpers/test_environment/test/events.nr

noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr

nventuro · 2026-02-26T19:52:57Z

noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr

-// experimental
-pub(crate) unconstrained fn get_private_events(
-    selector: EventSelector,
+pub unconstrained fn get_private_events<Event>(


Suggested change

pub unconstrained fn get_private_events<Event>(

/// Experimental - there may be breaking API changes.

pub unconstrained fn get_private_events<Event>(

We want to somehow flag this. I imagine something like get_private_events will very likely take some sort of filter or something.

If we're making this pub, we should also at the very least document that we only search for events in the last block.

Added the docs in f575bfa and this how they get rendered:

Do you like it?

BTW do you know if there is a way how the MAX_PRIVATE_EVENTS_PER_TXE_QUERY constant could get rendered there? I tried to Claude it but it says there is no way.

Hmm I wishit were more obvious. Perhaps we could do horizontal separators with ---?

like --- this

I don't follow. What is supposed to be more obvious? And where do you want me to place the separator?

noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr

nventuro · 2026-02-26T19:56:29Z

noir-projects/noir-contracts/contracts/app/token_contract/src/main.nr

-        from: AztecAddress,
-        to: AztecAddress,
-        amount: u128,
+    pub struct Transfer {


We probably want to either make all of these pub, or suggest that they are made pub.

Documented this in 908c4d6

Is that would you meant by suggesting making them pub, right?

I meant that the event macro should do it, linking to the doc piece you just wrote. We don't need pub though do we?

I was originally hesitant to make the event macro apply the pub there as it makes it feel a bit more magical (events are just structs but with some extra stuff) but given that by definition they are a piece of data to be consumed by "the world out of the contract" I came to agree that it makes sense to not be annoying here and just auto-expose it.

Addressed in 6da2825

But I have one question about this:

linking to the doc piece you just wrote

Isn't it strange to link from the event macro code docs to the doc piece I wrote given that the event macro docs are way more "low-level"? Or is that not what you meant?

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

AztecBot · 2026-02-27T07:20:44Z

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/a319774110c064b4�a319774110c064b48;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/duplicate_attestation_slash.test.ts (152s) (code: 0) group:e2e-p2p-epoch-flakes

docs/docs-developers/docs/aztec-nr/testing_contracts.md

noir-projects/aztec-nr/aztec/src/macros/utils.nr

docs/docs-developers/docs/aztec-nr/testing_contracts.md

noir-projects/aztec-nr/aztec/src/test/helpers/test_environment/test/events.nr

noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr

nventuro · 2026-03-03T15:52:18Z

noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr

+/// Returns up to `MAX_PRIVATE_EVENTS_PER_TXE_QUERY` private events of type `Event` that were emitted by
+/// `contract_address` and available in `scope`.


This is inaccurate as it is missing the fact that it only searches the last block. It also does not explain wtf scope is.

Somewhat addressed in 3361896

But I am not sure about this:

This is inaccurate as it is missing the fact that it only searches the last block.

Do you mean by that "up to last block"?

By searching only the last block I imagine events emitted in the last block. Or is your mental model here that "last block" contains any state that got accumulated by the chain up to that block?

I don't know the code of TXE enough to be sure here.

noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr

noir-projects/noir-contracts/contracts/app/token_contract/src/test/utils.nr

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

Wraps the low-level oracle so users don't need to import and call the oracle directly. This provides a higher-level API consistent with the rest of TestEnvironment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Short first paragraph, clarify that only last block is searched, explain what scope means (event recipient), mention self.emit, and point users to TestEnvironment method instead of using the oracle directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Move experimental warning to top of section as a note block. Use env.get_private_events instead of importing the oracle directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ents_from_aztec.nr

benesjan · 2026-03-05T04:45:56Z

@nventuro Re-requested a review here even though the PR is not yet finished as I need some clarifications - left the questions in unresolved discussions above.

Also please LMK if merging merge-train/fairies to this branch messed up the Github view of "changes since last review". If it messed it up I will wait with resolving conflicts for after the review finishes next time.

benesjan force-pushed the 02-18-feat_testing_private_events_from_aztec.nr branch from e3ee438 to 21ff0cc Compare February 18, 2026 14:12

benesjan mentioned this pull request Feb 19, 2026

feat(token): emit Transfer event on public transfer #20198

Open

benesjan force-pushed the 02-18-feat_testing_private_events_from_aztec.nr branch from 557d5c7 to 58006da Compare February 20, 2026 08:12

benesjan commented Feb 20, 2026

View reviewed changes

noir-projects/noir-protocol-circuits/crates/serde/src/serialization.nr Show resolved Hide resolved

benesjan changed the base branch from merge-train/fairies to graphite-base/20640 February 20, 2026 12:02

benesjan force-pushed the 02-18-feat_testing_private_events_from_aztec.nr branch from 58006da to 7d799f3 Compare February 20, 2026 12:02

benesjan changed the base branch from graphite-base/20640 to 02-20-fix_txe_committing_after_txs February 20, 2026 12:03

benesjan mentioned this pull request Feb 20, 2026

fix(txe): committing after txs #20714

Merged

benesjan force-pushed the 02-18-feat_testing_private_events_from_aztec.nr branch from 7d799f3 to 74001a2 Compare February 20, 2026 12:06

benesjan added ci-draft Run CI on draft PRs. and removed ci-draft Run CI on draft PRs. labels Feb 20, 2026

Base automatically changed from 02-20-fix_txe_committing_after_txs to merge-train/fairies February 23, 2026 10:19

benesjan added 5 commits February 26, 2026 04:43

feat: testing private events from Aztec.nr

9982c5e

cleanup

d4522ea

wip

c71b27e

wip

cc27052

cleanup

7dc8ff2

benesjan force-pushed the 02-18-feat_testing_private_events_from_aztec.nr branch from 74001a2 to 7dc8ff2 Compare February 26, 2026 04:43

benesjan commented Feb 26, 2026

View reviewed changes

noir-projects/aztec-nr/aztec/src/macros/utils.nr Show resolved Hide resolved

benesjan commented Feb 26, 2026

View reviewed changes

noir-projects/aztec-nr/aztec/src/test/helpers/test_environment/test/events.nr Show resolved Hide resolved

final cleanup

9c9d4f3

benesjan marked this pull request as ready for review February 26, 2026 04:58

benesjan requested review from LeilaWang and nventuro as code owners February 26, 2026 04:58

benesjan requested review from nchamo and removed request for LeilaWang and nventuro February 26, 2026 06:00

nchamo reviewed Feb 26, 2026

View reviewed changes

noir-projects/aztec-nr/aztec/src/test/helpers/test_environment/test/events.nr Outdated Show resolved Hide resolved

noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr Show resolved Hide resolved

nventuro reviewed Feb 26, 2026

View reviewed changes

benesjan marked this pull request as draft February 27, 2026 03:49

benesjan and others added 4 commits February 27, 2026 04:50

Update noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr

956a329

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

less verbose tests

a8f6119

event length from oracle check

fb4b18a

docs

908c4d6

benesjan force-pushed the 02-18-feat_testing_private_events_from_aztec.nr branch from 3660419 to 908c4d6 Compare February 27, 2026 06:25

code docs

f575bfa

benesjan marked this pull request as ready for review February 27, 2026 07:04

benesjan requested a review from nventuro February 27, 2026 07:25

nventuro requested changes Mar 3, 2026

View reviewed changes

benesjan marked this pull request as draft March 4, 2026 10:45

benesjan and others added 10 commits March 4, 2026 11:46

Update docs/docs-developers/docs/aztec-nr/testing_contracts.md

a013644

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

Update noir-projects/aztec-nr/aztec/src/macros/utils.nr

b720897

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

Add get_private_events method to TestEnvironment

0e950f1

Wraps the low-level oracle so users don't need to import and call the oracle directly. This provides a higher-level API consistent with the rest of TestEnvironment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Use env.get_private_events instead of oracle in internal tests

67daad1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Use env.get_private_events instead of oracle in token test utils

f5cf5e6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update testing docs to use env.get_private_events and move warning

33300d0

Move experimental warning to top of section as a note block. Use env.get_private_events instead of importing the oracle directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

moving docs only to test env function

f6e9915

clarifying docs

3361896

Merge branch 'merge-train/fairies' into 02-18-feat_testing_private_ev…

3e68a81

…ents_from_aztec.nr

event macro making the struct pub

6da2825

benesjan requested a review from nventuro March 5, 2026 05:17

Base automatically changed from merge-train/fairies to next March 26, 2026 04:08

	pub unconstrained fn get_private_events<Event>(
	/// Experimental - there may be breaking API changes.
	pub unconstrained fn get_private_events<Event>(

		/// Returns up to `MAX_PRIVATE_EVENTS_PER_TXE_QUERY` private events of type `Event` that were emitted by
		/// `contract_address` and available in `scope`.

Conversation

benesjan commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benesjan commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benesjan commented Feb 26, 2026

Uh oh!

nchamo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benesjan Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AztecBot commented Feb 27, 2026

Flakey Tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benesjan Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benesjan commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

benesjan commented Feb 18, 2026 •

edited

Loading

benesjan commented Feb 18, 2026 •

edited

Loading

benesjan Feb 27, 2026 •

edited

Loading

benesjan Mar 5, 2026 •

edited

Loading

benesjan commented Mar 5, 2026 •

edited

Loading