Skip to content

fix(prover): store simulation duration as ms #20460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 1 commit into from
Feb 12, 2026
Merged

fix(prover): store simulation duration as ms #20460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions yarn-project/bb-prover/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,18 @@ export class ProverInstrumentation {
circuitName: CircuitName,
timerOrMS: Timer | number,
) {
const s = typeof timerOrMS === 'number' ? timerOrMS / 1000 : timerOrMS.s();
this[metric].record(s, {
[Attributes.PROTOCOL_CIRCUIT_NAME]: circuitName,
});
// Simulation duration is stored in ms, while the others are stored in seconds
if (metric === 'simulationDuration') {
const ms = typeof timerOrMS === 'number' ? timerOrMS : timerOrMS.ms();
this[metric].record(Math.trunc(ms), {
[Attributes.PROTOCOL_CIRCUIT_NAME]: circuitName,
});
} else {
const s = typeof timerOrMS === 'number' ? timerOrMS / 1000 : timerOrMS.s();
this[metric].record(s, {
[Attributes.PROTOCOL_CIRCUIT_NAME]: circuitName,
});
}
}

/**
Expand Down
Loading