Draft
Conversation
IlyasRidhuan
commented
Feb 12, 2026
| import { schemas } from '../../schemas/index.js'; | ||
|
|
||
| export const ProtocolContractsNames = ['classRegistry', 'feeJuice', 'instanceRegistry', 'multiCallEntrypoint'] as const; | ||
| export const ProtocolContractsNames = ['feeJuice', 'classRegistry', 'instanceRegistry', 'authRegistry'] as const; |
Contributor
Author
There was a problem hiding this comment.
authRegistry wasn't in here before but IIUC this is for user-facing code so wasnt necessary.
But it's probably better to be consistent with the naming lists here
IlyasRidhuan
requested review from
LHerskind,
Maddiaa0,
fcarreiro,
jeanmon and
just-mitch
as code owners
IlyasRidhuan
force-pushed
the
ir/02-12-fix_update_protocol_contracts_list
branch
from
a9998af to
713e2e7
Compare
IlyasRidhuan
changed the base branch from
merge-train/spartan
to
graphite-base/20436
IlyasRidhuan
force-pushed
the
graphite-base/20436
branch
from
8570cca to
44a8742
Compare
IlyasRidhuan
force-pushed
the
ir/02-12-fix_update_protocol_contracts_list
branch
from
713e2e7 to
96be3df
Compare
IlyasRidhuan
force-pushed
the
ir/02-12-fix_update_protocol_contracts_list
branch
2 times, most recently
from
dde0998 to
d7f135d
Compare
IlyasRidhuan
force-pushed
the
ir/02-12-fix_update_protocol_contracts_list
branch
from
d7f135d to
30b0d7a
Compare
LeilaWang
approved these changes
Feb 13, 2026
Contributor
LeilaWang
left a comment
LeilaWang
left a comment
There was a problem hiding this comment.
All look good to me! Thanks for changing this 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the protocol contract lists to only be: Fee Juice, Class Registry, Instance Registry, and AuthWit Registry. They're also now consistently ordered as such.