Skip to content

fix(validator): do not process proposals from self #20314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 1 commit into from
Feb 9, 2026
Merged

fix(validator): do not process proposals from self #20314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions yarn-project/validator-client/src/validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,15 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
return false;
}

// Ignore proposals from ourselves (may happen in HA setups)
if (this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
Copy link
Collaborator

@PhilWindle PhilWindle Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this isn't going to prohibit propagation?

Copy link
Contributor Author

@spalladino spalladino Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this kicks in after the inivial validations run in the libp2p service that gate propagation

this.log.warn(`Ignoring block proposal from self for slot ${slotNumber}`, {
proposer: proposer.toString(),
slotNumber,
});
return false;
}

// Check if we're in the committee (for metrics purposes)
const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
const partOfCommittee = inCommittee.length > 0;
Expand Down Expand Up @@ -453,6 +462,15 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
return undefined;
}

// Ignore proposals from ourselves (may happen in HA setups)
if (this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
this.log.warn(`Ignoring block proposal from self for slot ${slotNumber}`, {
proposer: proposer.toString(),
slotNumber,
});
return undefined;
}

// Check that I have any address in current committee before attesting
const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
const partOfCommittee = inCommittee.length > 0;
Expand Down
Loading