Skip to content

chore: Update index.js so that HAS_ZK and PUBLIC_INPUTS variables must always be set in tests #19884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
federicobarbacovi merged 1 commit into from
Jan 23, 2026
Merged

chore: Update index.js so that HAS_ZK and PUBLIC_INPUTS variables must always be set in tests #19884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 7 additions & 20 deletions barretenberg/acir_tests/sol-test/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,6 @@ const GEMINI_CHALLENGE_IN_SUBGROUP = "0x835eb8f7";
// 5. Run the test against the deployed contract
// 6. Kill the anvil instance

const getEnvVarCanBeUndefined = (envvar) => {
const varVal = process.env[envvar];
if (!varVal) {
return false;
}
return varVal;
};

const getEnvVar = (envvar) => {
const varVal = process.env[envvar];
if (!varVal) {
Expand All @@ -55,7 +47,7 @@ const [test, verifier] = await Promise.all([
fsPromises.readFile(verifierPath, encoding),
]);

const hasZK = getEnvVarCanBeUndefined("HAS_ZK");
const hasZK = getEnvVar("HAS_ZK");

export const compilationInput = {
language: "Solidity",
Expand Down Expand Up @@ -230,7 +222,6 @@ const killAnvil = () => {
console.log(testName, " complete");
};

// TODO(https://github.com/AztecProtocol/barretenberg/issues/1316): Clean this code up. We are trying to use this logic for three different flows: bb plonk, bb honk, and bbjs honk, and all three have different setups.
try {
const proofPath = getEnvVar("PROOF");

Expand All @@ -239,7 +230,7 @@ try {
const proof = readFileSync(proofPath);
proofStr = proof.toString("hex");

let publicInputsPath = getEnvVarCanBeUndefined("PUBLIC_INPUTS");
let publicInputsPath = getEnvVar("PUBLIC_INPUTS");
var publicInputs = [];
let numExtraPublicInputs = 0;
let extraPublicInputs = [];
Expand All @@ -251,15 +242,11 @@ try {
[numExtraPublicInputs, extraPublicInputs] = readPublicInputs(proofAsFields);
}

// Read public inputs from binary file if available
if (publicInputsPath) {
const publicInputsBinary = readFileSync(publicInputsPath);
const innerPublicInputs = binaryToFields(publicInputsBinary);
publicInputs = innerPublicInputs.concat(extraPublicInputs);
} else {
// for plonk, the extraPublicInputs are all of the public inputs
publicInputs = extraPublicInputs;
}
// Read public inputs from binary file
const publicInputsBinary = readFileSync(publicInputsPath);
const innerPublicInputs = binaryToFields(publicInputsBinary);
publicInputs = innerPublicInputs.concat(extraPublicInputs);

proofStr = proofStr.substring(64 * numExtraPublicInputs);
proofStr = "0x" + proofStr;

Expand Down
Loading