refactor(e2e): unify setup and setupFromFresh into single function#19532
Merged
spalladino merged 2 commits intonextfrom Jan 14, 2026
Merged
refactor(e2e): unify setup and setupFromFresh into single function#19532spalladino merged 2 commits intonextfrom
spalladino merged 2 commits intonextfrom
Conversation
spalladino
added
the
ci-no-fail-fast
spalladino
force-pushed
the
palla/remove-snapshot-manager-2
branch
from
a96c518 to
3c7ccaf
Compare
spalladino
force-pushed
the
palla/unify-e2e-setup
branch
3 times, most recently
from
e4d267e to
e603d04
Compare
spalladino
force-pushed
the
palla/unify-e2e-setup
branch
2 times, most recently
from
7807a0e to
f6029c9
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
spalladino
force-pushed
the
palla/unify-e2e-setup
branch
from
f6029c9 to
e55045d
Compare
PhilWindle
approved these changes
Jan 14, 2026
Collaborator
PhilWindle
left a comment
PhilWindle
left a comment
There was a problem hiding this comment.
Nice consolidation. Just a question of use of as any.
spalladino
force-pushed
the
palla/unify-e2e-setup
branch
from
75d6a5e to
4f2d1c5
Compare
Consolidate the two e2e test setup functions into a unified setup function in setup.ts. Both utils.ts and snapshot_manager.ts now re-export from setup.ts with backward-compatible wrappers. Key changes: - Create setup.ts with unified EndToEndContext type and setup function - Add aztecNodeConfig alias for backward compatibility with SubsystemsContext - snapshot_manager.ts provides SubsystemsContext type (with non-optional fields) and setupFromFresh wrapper function - utils.ts re-exports from setup.ts for full backward compatibility - Both fundSponsoredFPC and skipAccountDeployment flags added to SetupOptions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ed setup Completes the migration from setupFromFresh to the unified setup API by: - Deleting fixtures/snapshot_manager.ts entirely - Migrating all 9 test fixtures from setupFromFresh to setup - Replacing SubsystemsContext with EndToEndContext throughout - Updating field access (aztecNode → aztecNodeService, added ! assertions) - Properly merging l1ContractsArgs at all callsites - Setting fundSponsoredFPC: true and skipAccountDeployment: true everywhere All tests verified with tsc, format, and lint. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
spalladino
force-pushed
the
palla/unify-e2e-setup
branch
from
4f2d1c5 to
c576e6d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ludamad
added a commit
that referenced
this pull request
Feb 23, 2026
Slide 19 (§4 insights · PR correlation): two-column layout showing which PRs caused each weekly flake spike and which fixes produced each recovery: Spikes: - W02 (2,647 flakes): Santiago refactors #19532/#19509/#19564 exposed timing races across p2p/epoch simultaneously - W04 (935 flakes): PhilWindle #19982 added cross-chain mbps tests without pre-deflaking — valid_epoch_pruned_slash 0→346 events - W06 (850 flakes): three high-risk PRs merged same day (#20047 peer scoring, #20241 max checkpoints→32, #20257 hash constants) Fixes: - W03 recovery: Santiago #19914 — checkpointed chain tip for PXE (root fix; PXE was using latest not checkpointed block) - W05 recovery: Santiago #20088 slasher multi-block fix + #20140 discv5 deflake + GCP step-down (−6 testbed namespaces) - W07 improvement: Santiago #20351 mbps fix (p2p_client 311→0), #20462 remove hardcoded 10s timeout, ludamad #20613 CI parallelism Also: correct three factual errors spotted during full review — - Summary: next P50 is growing (+10% in 3 weeks), not stable - Flake trend W07 note: e2e-p2p-epoch-flakes dropped 373×, not just "251 flakes lowest since December" - Gaps slide: replaced stale "ci_phases broken" card with GCP egress costs gap (bc→awk fix is deployed; egress attribution is the gap now)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the two e2e test setup functions (
setupfrom utils.ts andsetupFromFreshfrom snapshot_manager.ts) into a unifiedsetupfunction in a newsetup.tsfileChanges
setup.tswith:EndToEndContexttype (includesaztecNodeConfigalias for backward compatibility)setupfunction that handles all setup scenariosfundSponsoredFPC,skipAccountDeployment,l1ContractsArgssnapshot_manager.tssetupFromFreshto usesetup, adjusting options to match existing behaviour🤖 Generated with Claude Code