Skip to content

fix: circuits should not link openmp with -DMULTITHREADING #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 1 commit into from
Sep 1, 2023
Merged

fix: circuits should not link openmp with -DMULTITHREADING #1929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions circuits/cpp/cmake/threading.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,26 @@
if(MULTITHREADING)
find_package(OpenMP REQUIRED)
message(STATUS "Multithreading is enabled.")
link_libraries(OpenMP::OpenMP_CXX)
add_compile_options(-pthread)
add_link_options(-pthread)
if(WASM)
add_compile_options(--target=wasm32-wasi-threads)
add_link_options(--target=wasm32-wasi-threads)
endif()
#add_compile_options(-fsanitize=thread)
#add_link_options(-fsanitize=thread)
else()
message(STATUS "Multithreading is disabled.")
add_definitions(-DNO_MULTITHREADING -DBOOST_SP_NO_ATOMIC_ACCESS)
add_definitions(-DNO_MULTITHREADING)
set(OMP_MULTITHREADING OFF)
endif()

if(OMP_MULTITHREADING)
find_package(OpenMP REQUIRED)
message(STATUS "OMP multithreading is enabled.")
link_libraries(OpenMP::OpenMP_CXX)
else()
message(STATUS "OMP multithreading is disabled.")
add_definitions(-DNO_OMP_MULTITHREADING)
endif()

if(DISABLE_TBB)
Expand Down