Include new contract data function tree root in tx hash#188
Include new contract data function tree root in tx hash#188spalladino merged 12 commits intomasterfrom
Conversation
4ae9246 to
65ea927
Compare
ba5780a to
356689a
Compare
| import { BarretenbergWasm } from '../../wasm/index.js'; | ||
| import { WasmWrapper } from '@aztec/foundation/wasm'; | ||
|
|
||
| export class Grumpkin { |
There was a problem hiding this comment.
Not the biggest fan of the Wrapper name, the intent was that the generic concept was called WasmModule
There was a problem hiding this comment.
Almost any utility class could be called a Wrapper, is my reasoning, but it represents what it wraps
There was a problem hiding this comment.
Agree, and WasmModule was also my first choice for a name, but there's already a lower level WasmModule in the repo.
There was a problem hiding this comment.
Yeah I created that one, it was meant to provide everything needed to just pass around without introducing base classes
There was a problem hiding this comment.
I suppose that's not quite right though with async call state
| COPY l2-block l2-block | ||
| COPY tx tx | ||
| COPY unverified-data unverified-data | ||
| COPY . . |
There was a problem hiding this comment.
+1 if we're going to have a dependency system no reason to copy dependencies one by one (which mostly can help with docker figuring out its own dependencies)
ludamad
left a comment
There was a problem hiding this comment.
LGTM other than naming comment
|
I cannot come up with a better name for now. I'll merge and keep thinking about it. |
Note that, since we now depend on circuits for explicitly calculating contract leaves via the
computeContractLeafcbind, the primitives wasm is left unused. I'm leaving it as part of the PR since we can leverage it in the future for more lightweight dependencies, but I wouldn't worry about this atm.Depends on AztecProtocol/aztec3-circuits#178
Fixes #154