Skip to content

chore(1074): remove read request data from final private kernel circuit public inputs#1840

Merged
jeanmon merged 12 commits intomasterfrom
jm/1074-remove-rr-final-kernel-input
Aug 30, 2023
Merged

chore(1074): remove read request data from final private kernel circuit public inputs#1840
jeanmon merged 12 commits intomasterfrom
jm/1074-remove-rr-final-kernel-input

Conversation

@jeanmon
Copy link
Contributor

@jeanmon jeanmon commented Aug 28, 2023 •
edited
Loading

Resolves #1074

Refactor task consisting in defining a specific struct for the public inputs of final ordering private kernel circuit. This new struct is named: KernelCircuitPublicInputsFinal
This struct is identical to KernelCircuitPublicInputs except that we trimmed the 4 following members from CombinedAccumulatedData (a struct named FinalAccumulatedData was introduced for this purpose):

  • read_requests
  • read_request_membership_witnesses
  • public_data_update_requests
  • public_data_reads

In addition, one commit which resolves #1865 was added.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@jeanmon jeanmon changed the title Jm/1074 remove rr final kernel input chore(1074): remove read request data from final private kernel circuit public inputs Aug 28, 2023
@jeanmon jeanmon force-pushed the jm/1074-remove-rr-final-kernel-input branch 10 times, most recently from 8b9358f to a7ebe5d Compare August 29, 2023 18:38
@jeanmon jeanmon marked this pull request as ready for review August 30, 2023 08:30
@jeanmon jeanmon force-pushed the jm/1074-remove-rr-final-kernel-input branch from a7ebe5d to e1489d1 Compare August 30, 2023 08:30
@jeanmon jeanmon requested review from benesjan and suyash67 August 30, 2023 08:33
jeanmon
jeanmon commented Aug 30, 2023
View reviewed changes
circuits/cpp/src/aztec3/circuits/kernel/private/common.cpp
}
}

void common_initialise_end_values(PreviousKernelData<NT> const& previous_kernel,
Copy link
Contributor Author

@jeanmon jeanmon Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to make this one templated and moved to header file.

benesjan
benesjan approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jeanmon jeanmon force-pushed the jm/1074-remove-rr-final-kernel-input branch 2 times, most recently from 57bed33 to 2835543 Compare August 30, 2023 12:37
@jeanmon jeanmon force-pushed the jm/1074-remove-rr-final-kernel-input branch from fcc75e9 to fd58d34 Compare August 30, 2023 13:37
@jeanmon jeanmon force-pushed the jm/1074-remove-rr-final-kernel-input branch from fd58d34 to 26cefe1 Compare August 30, 2023 13:38
@jeanmon jeanmon merged commit c61557a into master Aug 30, 2023
@jeanmon jeanmon deleted the jm/1074-remove-rr-final-kernel-input branch August 30, 2023 14:10
@github-actions github-actions bot mentioned this pull request Aug 30, 2023
Merged
PhilWindle pushed a commit that referenced this pull request Aug 30, 2023
@github-actions
chore(master): release 0.1.0-alpha49 (#1882)
685e3a9 
🤖 I have created a new Aztec Packages release
---


##
[0.1.0-alpha49](v0.1.0-alpha48...v0.1.0-alpha49)
(2023-08-30)


### Features

* Generate public context contract interfaces
([#1860](#1860))
([2f4045e](2f4045e)),
closes
[#1782](#1782)


### Bug Fixes

* Do not warn on mismatched cli/sandbox version
([#1894](#1894))
([a44a0f6](a44a0f6))
* remove extra transfer arg in CLI Guide
([#1887](#1887))
([55728b8](55728b8))
* Reset keccak var inputs to 0
([#1881](#1881))
([382f07e](382f07e))


### Miscellaneous

* **1074:** remove read request data from final private kernel circuit
public inputs
([#1840](#1840))
([c61557a](c61557a))
* Reenable and refactor nested calls e2e tests
([#1868](#1868))
([570de80](570de80)),
closes
[#1587](#1587)
* Update formatting
([#1874](#1874))
([fb973ca](fb973ca))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benesjan benesjan benesjan approved these changes

@suyash67 suyash67 suyash67 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
A3
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: rename or cleanup makeEmpty functions in TS factories Ordering circuit's public inputs should not include read requests

3 participants

@jeanmon @benesjan @suyash67