Skip to content

chore: use 2^19 as MAX_CIRCUIT_SIZE for NodeJS CLI #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kobyhallx merged 2 commits into from
Aug 28, 2023
Merged

chore: use 2^19 as MAX_CIRCUIT_SIZE for NodeJS CLI #1834

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
178f0cc
use 2^19 for NodeJS CLI
kevaundray Aug 26, 2023
7a43701
prettier
kevaundray Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions circuits/cpp/barretenberg/ts/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,13 @@ import { Command } from 'commander';
createDebug.log = console.error.bind(console);
const debug = createDebug('bb.js');

// Maximum we support natively. It is 2^19 for browser.
const MAX_CIRCUIT_SIZE = 2 ** 23;
// Maximum we support in node and the browser is 2^19.
// This is because both node and browser use barretenberg.wasm.
//
// This is not a restriction in the bb binary and one should be
// aware of this discrepancy, when creating proofs in bb versus
// creating the same proofs in the node CLI.
const MAX_CIRCUIT_SIZE = 2 ** 19;

function getBytecode(bytecodePath: string) {
const encodedCircuit = readFileSync(bytecodePath, 'utf-8');
Expand Down