Skip to content

fix(aztec-nr): Avoid relying on unquoted integers changing types#18299

Merged
jfecher merged 1 commit intonextfrom
jf/preserve-int-type
Nov 11, 2025
Merged

fix(aztec-nr): Avoid relying on unquoted integers changing types#18299
jfecher merged 1 commit intonextfrom
jf/preserve-int-type

Conversation

@jfecher
Copy link
Contributor

@jfecher jfecher commented Nov 10, 2025

After noir-lang/noir#10330, noir will start enforcing the types of unquoted integers remain the same type. Before, when you unquoted an integer such as let n: u32 = 4; e.g. in quote { let x = $n; } the unquoted n would be a polymorphic integer literal of any type. With the above PR, it unquotes instead to let x = 4u32; - the type is preserved. We consider it a bug to rely on the previous behavior, and there were 3 instances of it in aztec-nr so this is a patch for those cases.

@jfecher jfecher requested a review from nventuro November 10, 2025 13:43
@AztecBot
Copy link
Collaborator

AztecBot commented Nov 10, 2025

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033[38;2;188;109;208mFLAKED\033[0m (\033[38;2;250;217;121m8;;http://ci.aztec-labs.com/9df8601507c07397�9df8601507c073978;;�\033[0m): noir-projects/scripts/run_test.sh noir-protocol-circuits blob blob_batching::tests::test_no_extra_blob_fields (250s) (code: 134) (\033[38;2;188;109;208mjfecher\033[0m: fix(aztec-nr): Avoid relying on unquoted integers changing types (#18299))

Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nventuro nventuro added this pull request to the merge queue Nov 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2025
@jfecher jfecher added this pull request to the merge queue Nov 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2025
@jfecher jfecher added this pull request to the merge queue Nov 11, 2025
Merged via the queue into next with commit 9c6e7d6 Nov 11, 2025
14 checks passed
@jfecher jfecher deleted the jf/preserve-int-type branch November 11, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants