fix(aztec-nr): Avoid relying on unquoted integers changing types#18299
Merged
fix(aztec-nr): Avoid relying on unquoted integers changing types#18299
Conversation
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After noir-lang/noir#10330, noir will start enforcing the types of unquoted integers remain the same type. Before, when you unquoted an integer such as
let n: u32 = 4;e.g. inquote { let x = $n; }the unquotednwould be a polymorphic integer literal of any type. With the above PR, it unquotes instead tolet x = 4u32;- the type is preserved. We consider it a bug to rely on the previous behavior, and there were 3 instances of it in aztec-nr so this is a patch for those cases.