Merged
Conversation
spypsy
approved these changes
Oct 29, 2025
| custom_settings = { | ||
| "nodeType" = "rpc" | ||
| "replicaCount" = var.RPC_REPLICAS | ||
| "node.env.NETWORK" = var.NETWORK |
Contributor
Author
There was a problem hiding this comment.
yes! The network env var is already handled in the underlying helm chart. This was duplicating the env definition
alexghr
force-pushed
the
ag/slim-fisherman-deployments
branch
2 times, most recently
from
994acfb to
826d4c4
Compare
alexghr
force-pushed
the
ag/slim-fisherman-deployments
branch
from
826d4c4 to
7227f1c
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Collaborator
|
❌ Failed to cherry-pick to |
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #18060 and removes some components that are not going to be necessary for fisherman networks (like web3signer)