Skip to content

fix: Fix vk test#18057

Merged
federicobarbacovi merged 4 commits intomerge-train/barretenbergfrom
fb/fix_format_and_vks_test
Oct 30, 2025
Merged

fix: Fix vk test#18057
federicobarbacovi merged 4 commits intomerge-train/barretenbergfrom
fb/fix_format_and_vks_test

Conversation

@federicobarbacovi
Copy link
Contributor

@federicobarbacovi federicobarbacovi commented Oct 29, 2025 •
edited
Loading

Update test vk to use bb-chonk. Forced update of vks to avoid breaking changes. No change to circuits (same vks, just different upload target)

@federicobarbacovi federicobarbacovi self-assigned this Oct 29, 2025
@federicobarbacovi federicobarbacovi marked this pull request as ready for review October 29, 2025 17:53
@federicobarbacovi federicobarbacovi force-pushed the fb/fix_format_and_vks_test branch from 6f1b865 to ba43ed3 Compare October 30, 2025 09:27
@federicobarbacovi federicobarbacovi force-pushed the fb/fix_format_and_vks_test branch from ba43ed3 to d69ad9d Compare October 30, 2025 09:27
@federicobarbacovi federicobarbacovi changed the title fix: Fix format.sh and vk test fix: Fix vk test Oct 30, 2025
@federicobarbacovi federicobarbacovi merged commit 1a324e9 into merge-train/barretenberg Oct 30, 2025
9 checks passed
@federicobarbacovi federicobarbacovi deleted the fb/fix_format_and_vks_test branch October 30, 2025 09:40
@AztecBot AztecBot mentioned this pull request Oct 30, 2025
Merged
federicobarbacovi added a commit that referenced this pull request Oct 30, 2025
@federicobarbacovi
Squash commit of fb/ec_operation_audit_1 to test
cf551ba 
commit 5168715
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 09:58:17 2025 +0000

    Update vks, minor changes

commit 45acdbf
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 16:28:07 2025 +0000

    Address comments

commit 8a9cff3
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 12:54:37 2025 +0000

    Restructuring

commit bad1c0e
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 12:02:16 2025 +0000

    Refactoring

commit d9b0dfd
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Tue Oct 28 15:02:53 2025 +0000

    Minor change + add assertion constant predicate is true

commit 5dc6f08
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Tue Oct 28 09:59:40 2025 +0000

    Small cleanup

commit 7d41783
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Mon Oct 27 15:41:43 2025 +0000

    Refactoring

commit 1a324e9
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 09:40:15 2025 +0000

    fix: Fix vk test (#18057)

    Update test vk to use `bb-chonk`. Forced update of vks to avoid breaking
    changes. No change to circuits (same vks, just different upload target)

commit d9d6ac8
Merge: becf9a5 6fe8217
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 02:43:00 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 6fe8217
Merge: c8ef782 51c0086
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 22:41:37 2025 -0400

    fix: revert squash_pr.sh (#18082)

commit 51c0086
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 22:41:13 2025 -0400

    fix: revert squash_pr.sh

    I had introduced issues

commit becf9a5
Merge: 7440370 c8ef782
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 00:51:15 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit c8ef782
Merge: 328d4a9 ae2ec47
Author: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
Date:   Thu Oct 30 00:08:53 2025 +0000

    chore: remappings to avoid nasty lib (#18004)

    Figured out that we can use profile based remappings in foundry to
    insert different versions of the blob library based on whether we are
    executing as part of a test or for deployment.

    By default we will now be using a bloblib for testing. For deployments,
    we will need to use `FOUNDRY_PROFILE=deployment` to compile without the
    cheatcodes.

commit 7440370
Merge: 15a9796 328d4a9
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 00:00:24 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 15a9796
Merge: 29cf60c 12ba368
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:56:28 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 29cf60c
Merge: 5bb2938 97cd64c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:47:55 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 5bb2938
Merge: 62a00e8 d07a493
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:42:00 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 328d4a9
Merge: 12ba368 666f2ca
Author: spypsy <spypsy@users.noreply.github.com>
Date:   Wed Oct 29 23:25:59 2025 +0000

    fix: no new blocks alerting (#18063)

    - Alert when no block data can be loaded by our metrics dashboard
    - bonus step: use `increase` which handles missing / weird (reset) data
    more robustly

commit 666f2ca
Author: spypsy <6403450+spypsy@users.noreply.github.com>
Date:   Wed Oct 29 23:25:36 2025 +0000

    fix: no new blocks alerting

    - Alert when no block data can be loaded by our metrics dashboard
    - bonus step: use `increase` which handles missing / weird (reset) data more robustly

commit ae2ec47
Author: LHerskind <16536249+LHerskind@users.noreply.github.com>
Date:   Wed Oct 29 23:15:05 2025 +0000

    chore: remappings to avoid nasty lib

commit 12ba368
Merge: 97cd64c 292c16b
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 23:13:16 2025 +0000

    chore: copy bb-avm into the release-image (#18042)

    Copy `bb-avm` instead of `bb` into the release image

commit 97cd64c
Merge: d07a493 6be1187
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 23:12:31 2025 +0000

    chore: disable proof submission in fisherman networks (#18060)

    This PR flips the `PROVER_NODE_DISABLE_PROOF_PUBLISH` (disabling txs)
    for fisherman deployments

commit d07a493
Merge: c83136d e9abfaa
Author: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
Date:   Wed Oct 29 23:02:38 2025 +0000

    feat: merge-train/spartan (#18045)

    BEGIN_COMMIT_OVERRIDE
    fix: Ignore duplicate p2p messages after validation (#18034)
    fix: Enforce max uncompressed size for p2p messages (#18048)
    fix: Check if slot is taken after proposer check in sequencer (#18051)
    END_COMMIT_OVERRIDE

commit 62a00e8
Merge: 267f8cd c83136d
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 21:56:43 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit e9abfaa
Merge: 27e78b0 c83136d
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 21:56:38 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit c83136d
Merge: c65514c bcc396a
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 21:17:05 2025 +0000

    refactor!: dropping pub context mutable refs (#17997)

    Closes
    https://linear.app/aztec-labs/issue/F-110/remote-mut-refs-to-public-context

    `PrivateContext` generally needs to be passed as a mutable reference to
    functions because it does actually hold state
    we're mutating. This is not the case for `PublicContext`, or
    `UtilityContext` - these are just marker objects that
    indicate the current execution mode and make available the correct
    subset of the API. For this reason we have dropped
    the mutable reference from the API.

    Marked as breaking change because a dev needs to manually update the
    type in case he passed the context around to custom functions.

commit 267f8cd
Author: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
Date:   Wed Oct 29 14:03:37 2025 -0700

    chore: remove gate estimation (#17879)

    Replace complex and inaccurate "gate estimation" methods with
    potentially inefficient but simple and accurate method that makes a copy
    of the circuit then finalizes it to get the true gate count. Such
    methods should only be used in tests/debugging anyway so the extra
    copying is not an issue.

commit 66ce2c6
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 16:57:50 2025 -0400

    fix: format.sh

commit 2dd13ec
Merge: 1518bd5 c65514c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:57:24 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 27e78b0
Merge: d51bd1c c65514c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:57:21 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit bcc396a
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 20:51:07 2025 +0000

    refactor: dropping pub context mutable refs

commit d51bd1c
Merge: 322aaea 1f74833
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:36:23 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 1518bd5
Merge: 99bad53 1f74833
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:36:22 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 99bad53
Merge: 609ce30 c4fd727
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:29:49 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 322aaea
Merge: f3e41c5 c4fd727
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:29:43 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit c65514c
Merge: 1f74833 19bed87
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 20:22:01 2025 +0000

    fix: fetch commands in squash-pr.sh (#18053)

commit 19bed87
Author: ludamad <163993+ludamad@users.noreply.github.com>
Date:   Wed Oct 29 20:02:57 2025 +0000

    fix: fetch commands in squash-pr.sh

commit 1f74833
Merge: c4fd727 9d86610
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 19:52:53 2025 +0000

    refactor!: renaming `#[internal]` as `#[only_self]` + updated tests (#17958)

    Closes
    https://linear.app/aztec-labs/issue/F-20/rename-internal-to-something-else-eg-externalprivate-only-self

    We want for internal to mean the same thing as in Solidity where
    internal function can be called only from the same contract and is also
    inlined (EVM JUMP opcode and not EVM CALL). The original implementation
    of our `#[internal]` macro also results in the function being callable
    only from the same contract but it results in a different call (hence it
    doesn't map to EVM JUMP). This is very confusing hence I am doing the
    rename in this PR.

    When checking whether the `#[only_self]` is tested I stumbled upon old
    e2e tests doing that. Instead of updating them decided to move them over
    to Noir.

    A true `#[internal]` will be introduced in a followup PR.

commit f3e41c5
Merge: d9e2913 6cb98cf
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:29:45 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 609ce30
Merge: 64a93f8 6cb98cf
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:29:41 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 9d86610
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 19:29:31 2025 +0000

    refactor: renaming #[internal] as #[only_self]

commit 6cb98cf
Merge: 201c61b e842bf1
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 15:28:16 2025 -0400

    chore: only run ASAN tests on non-tag CI runs (#18044)

commit c4fd727
Merge: e82ae5b 21f14ae
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 19:26:40 2025 +0000

    chore: fix attestation gathering alerts (#18040)

commit d9e2913
Merge: e19549e 201c61b
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:19:00 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 64a93f8
Merge: e011fe7 201c61b
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:18:37 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit e82ae5b
Merge: 6cb98cf f499360
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 19:14:36 2025 +0000

    fix: backport_to_staging.sh (#18066)

commit e19549e
Merge: dd5c104 ff7090f
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:09:53 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit e011fe7
Merge: 2d7dc9b ff7090f
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:09:48 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit f499360
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 15:03:46 2025 -0400

    fix: backport_to_staging.sh

commit 201c61b
Merge: ff7090f e55a877
Author: josh crites <jc@joshcrites.com>
Date:   Wed Oct 29 18:42:01 2025 +0000

    fix(docs): Improve nightly docs release workflow to check for published GitHub releases (#18052)

    adds a check that the latest nightly release was published before
    updating the docs

commit e55a877
Author: critesjosh <18372439+critesjosh@users.noreply.github.com>
Date:   Wed Oct 29 18:41:33 2025 +0000

    fix(docs): Improve nightly docs release workflow to check for published GitHub releases

    adds a check that the latest nightly release was published before updating the docs

    Co-authored-by: Josh Crites <jc@joshcrites.com>

commit ff7090f
Merge: 8ac5056 53e048f
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 18:31:22 2025 +0000

    refactor!: introducing `ContractSelf` (#17884)

    Closes
    https://linear.app/aztec-labs/issue/F-21/implement-the-self-pattern

    Implementing `ContractSelf` that is injected to all the external
    functions as `self`. In this PR I do minimal initial implementation and
    for this reason the implementation of `ContractSelf` doesn't handle
    much.

    I wrote quite detailed migration notes that should make it clear what
    this PR achieves if it's not already clear from the issue and this
    description.

    The juicy bits are in `aztec-nr` dir and the changes to contracts are
    just repetitive callsite updates.

commit 53e048f
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 18:24:35 2025 +0000

    refactor: introducing ContractSelf

commit dd5c104
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 15:21:50 2025 -0300

    fix: Check if slot is taken after proposer check in sequencer (#18051)

    Otherwise we would continuously warn that we cant propose since the slot
    was taken by someone else. This check needs to happen AFTER the proposer
    check passes.

commit 6be1187
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 18:10:54 2025 +0000

    chore: disable proof submission in fisherman networks

commit 8323b70
Merge: bdb3c85 8ac5056
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 17:55:43 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 2d7dc9b
Merge: a079c58 8ac5056
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 17:55:31 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 8ac5056
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 13:54:04 2025 -0400

    chore(ci): reduce azure dependency for helm install (#18056)

commit a079c58
Author: Jonathan Hao <jonathanpohsianghao@gmail.com>
Date:   Wed Oct 29 17:40:24 2025 +0000

    fix: add proper error handling for invalid short hash in VK test script (#18055)
    - Fixes silent failure when the pinned short hash is invalid in the VK
    test script
    - Adds explicit error checking for curl download and tar extraction
    - Provides clear error messages to help diagnose issues
    The script was failing silently when the pinned short hash was invalid
    because:
    1. The `curl | tar` pipeline with `&>/dev/null` suppressed all error
    messages
    2. No error checking was performed on the curl command
    3. Pipeline exit status only reflected tar, not curl failures

    This made it very difficult to diagnose why the script was failing when
    the S3 artifact didn't exist.
    - Split curl and tar into separate operations with individual error
    checking
    - Added descriptive error messages that indicate the likely cause
    (invalid hash)
    - Removed silent output redirection to allow visibility into failures
    - Added progress messages during download and extraction

    Co-authored-by: Claude <noreply@anthropic.com>

commit 70c4a3d
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 11:59:50 2025 -0400

    chore(bb): remove some is_curve checks (#18037)

    Co-authored-by: Aztec Bot <49558828+AztecBot@users.noreply.github.com>

commit bdb3c85
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 12:56:30 2025 -0300

    fix: Enforce max uncompressed size for p2p messages (#18048)

    See https://eips.ethereum.org/EIPS/eip-706#avoiding-dos-attacks

    Fixes A-209

commit 29dd84e
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 15:46:27 2025 +0000

    feat: Implement PairingPoints tagging mechanism (#17988)

    This PR implements a simple tagging mechanism for PairingPoints. We
    leverage this mechanism to be sure that when a ProverInstance is built
    from a builder all the PairingPoints that have been constructed in the
    builder have been aggregated into one (we always return a single pairing
    point) and the aggregated point has been set to public.

    Closes AztecProtocol/barretenberg#1571

commit 30d3d1b
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 10:08:35 2025 -0300

    fix: Ignore duplicate p2p messages after validation (#18034)

    Today we have 3 deduplication mechanisms for messages:

    1. The `fastMsgId` cache, where gossipsub deduplicates messages based on
    a hash computed over the compressed message buffer:

    ```ts
    export function fastMsgIdFn(rpcMsg: RPC.Message): string {
      if (rpcMsg.data) {
        return xxhash.h64Raw(rpcMsg.data, h64Seed).toString(16);
      }
      return '0000000000000000';
    }
    ```

    2. The `msgId` cache, where gossipsub deduplicates messages based on a
    hash computed over the topic and the decompressed message buffer:

    ```ts
    export function getMsgIdFn(message: Message) {
      const { topic } = message;

      const vec = [Buffer.from(topic), message.data];
      return sha256(Buffer.concat(vec)).subarray(0, 20);
    }
    ```

    3. The `msgIdSeenValidators` we manually implement in `LibP2PService`,
    where we deduplicate based on the `msgId` again (**not** using the
    custom `p2pMessageIdentifier` from `Gossipable`), but with a larger
    cache, based on capacity instead of TTL:

    ```ts
        const validator = topicType ? this.msgIdSeenValidators[topicType] : undefined;

        if (!validator || !validator.addMessage(msgId)) {
          this.instrumentation.incMessagePrevalidationStatus(false, topicType);
          this.node.services.pubsub.reportMessageValidationResult(msgId, source.toString(), TopicValidatorResult.Ignore);
          return { result: false, topicType };
        }
    ```

    All of these deduplications run **after** any validation is done. This
    PR adds an additional check for duplicates after validation, where we
    deduplicate against the attestation and tx pools, using the object
    identifiers:

    ```ts
      const validationFunc: () => Promise<ReceivedMessageValidationResult<BlockProposal>> = async () => {
          const block = BlockProposal.fromBuffer(payloadData);
          const isValid = await this.validateBlockProposal(source, block);
          const exists = isValid && (await this.mempools.attestationPool!.hasBlockProposal(block));

          this.logger.trace(`Validate propagated block proposal`, {
            isValid,
            exists,
            [Attributes.SLOT_NUMBER]: block.payload.header.slotNumber.toString(),
            [Attributes.P2P_ID]: source.toString(),
          });

          if (!isValid) {
            return { result: TopicValidatorResult.Reject };
          } else if (exists) {
            return { result: TopicValidatorResult.Ignore, obj: block };
          } else {
            return { result: TopicValidatorResult.Accept, obj: block };
          }
        };
    ```

    Returning `Ignore` to gossipsub causes it to delete the message from its
    `mcache` (but not from its `seenCache`) without penalizing the sender,
    and instructs it to not re-broadcast the message.

    Note that we cannot rely on the identifiers before validation since they
    could be forged: eg an attacker could pick up an identifier for a valid
    message, change its data with garbage, and forward it so it fails
    validation. When the real message is received afterwards, it gets
    rejected because it had previously failed. We need to run these id-based
    deduplications after validation so we know that the identifier
    corresponds to the payload.

    This change prevents a malicious message originator from slightly
    modifying part of its message and broadcasting it across the network
    repeatedly, causing it to be re-processed and re-broadcasted. Eg a
    malicious attester could rely on non-deterministic ecdsa signatures to
    produce different valid signatures for the same attestation and
    broadcast them all. This change would only accept the first attestation
    and reject all others.

    Fixes A-206

commit 292c16b
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 11:16:44 2025 +0000

    chore: copy bb-avm into the release-image

commit e842bf1
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 12:40:49 2025 +0000

    chore: only run ASAN tests on non-tag CI runs

commit 21f14ae
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 10:41:47 2025 +0000

    chore: fix attestation gathering alerts

commit e5d3c62
Merge: c38fa23 d22a23e
Author: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
Date:   Wed Oct 29 10:02:55 2025 +0000

    feat: merge-train/barretenberg (#18038)

    See
    [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md).
    This is a merge-train.
federicobarbacovi added a commit that referenced this pull request Oct 30, 2025
@federicobarbacovi
Squashed commit of fb/ec_operations_audit_1
2d513c0 
commit 7325e5d
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 12:14:37 2025 +0000

    Update vks

commit a1d04e5
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 12:07:30 2025 +0000

    Restore cast to boolean

commit 6685004
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 11:09:46 2025 +0000

    Fix changes

commit 5168715
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 09:58:17 2025 +0000

    Update vks, minor changes

commit 45acdbf
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 16:28:07 2025 +0000

    Address comments

commit 8a9cff3
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 12:54:37 2025 +0000

    Restructuring

commit bad1c0e
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 12:02:16 2025 +0000

    Refactoring

commit d9b0dfd
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Tue Oct 28 15:02:53 2025 +0000

    Minor change + add assertion constant predicate is true

commit 5dc6f08
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Tue Oct 28 09:59:40 2025 +0000

    Small cleanup

commit 7d41783
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Mon Oct 27 15:41:43 2025 +0000

    Refactoring

commit 1a324e9
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 09:40:15 2025 +0000

    fix: Fix vk test (#18057)

    Update test vk to use `bb-chonk`. Forced update of vks to avoid breaking
    changes. No change to circuits (same vks, just different upload target)

commit d9d6ac8
Merge: becf9a5 6fe8217
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 02:43:00 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 6fe8217
Merge: c8ef782 51c0086
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 22:41:37 2025 -0400

    fix: revert squash_pr.sh (#18082)

commit 51c0086
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 22:41:13 2025 -0400

    fix: revert squash_pr.sh

    I had introduced issues

commit becf9a5
Merge: 7440370 c8ef782
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 00:51:15 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit c8ef782
Merge: 328d4a9 ae2ec47
Author: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
Date:   Thu Oct 30 00:08:53 2025 +0000

    chore: remappings to avoid nasty lib (#18004)

    Figured out that we can use profile based remappings in foundry to
    insert different versions of the blob library based on whether we are
    executing as part of a test or for deployment.

    By default we will now be using a bloblib for testing. For deployments,
    we will need to use `FOUNDRY_PROFILE=deployment` to compile without the
    cheatcodes.

commit 7440370
Merge: 15a9796 328d4a9
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 00:00:24 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 15a9796
Merge: 29cf60c 12ba368
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:56:28 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 29cf60c
Merge: 5bb2938 97cd64c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:47:55 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 5bb2938
Merge: 62a00e8 d07a493
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:42:00 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 328d4a9
Merge: 12ba368 666f2ca
Author: spypsy <spypsy@users.noreply.github.com>
Date:   Wed Oct 29 23:25:59 2025 +0000

    fix: no new blocks alerting (#18063)

    - Alert when no block data can be loaded by our metrics dashboard
    - bonus step: use `increase` which handles missing / weird (reset) data
    more robustly

commit 666f2ca
Author: spypsy <6403450+spypsy@users.noreply.github.com>
Date:   Wed Oct 29 23:25:36 2025 +0000

    fix: no new blocks alerting

    - Alert when no block data can be loaded by our metrics dashboard
    - bonus step: use `increase` which handles missing / weird (reset) data more robustly

commit ae2ec47
Author: LHerskind <16536249+LHerskind@users.noreply.github.com>
Date:   Wed Oct 29 23:15:05 2025 +0000

    chore: remappings to avoid nasty lib

commit 12ba368
Merge: 97cd64c 292c16b
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 23:13:16 2025 +0000

    chore: copy bb-avm into the release-image (#18042)

    Copy `bb-avm` instead of `bb` into the release image

commit 97cd64c
Merge: d07a493 6be1187
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 23:12:31 2025 +0000

    chore: disable proof submission in fisherman networks (#18060)

    This PR flips the `PROVER_NODE_DISABLE_PROOF_PUBLISH` (disabling txs)
    for fisherman deployments

commit d07a493
Merge: c83136d e9abfaa
Author: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
Date:   Wed Oct 29 23:02:38 2025 +0000

    feat: merge-train/spartan (#18045)

    BEGIN_COMMIT_OVERRIDE
    fix: Ignore duplicate p2p messages after validation (#18034)
    fix: Enforce max uncompressed size for p2p messages (#18048)
    fix: Check if slot is taken after proposer check in sequencer (#18051)
    END_COMMIT_OVERRIDE

commit 62a00e8
Merge: 267f8cd c83136d
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 21:56:43 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit e9abfaa
Merge: 27e78b0 c83136d
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 21:56:38 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit c83136d
Merge: c65514c bcc396a
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 21:17:05 2025 +0000

    refactor!: dropping pub context mutable refs (#17997)

    Closes
    https://linear.app/aztec-labs/issue/F-110/remote-mut-refs-to-public-context

    `PrivateContext` generally needs to be passed as a mutable reference to
    functions because it does actually hold state
    we're mutating. This is not the case for `PublicContext`, or
    `UtilityContext` - these are just marker objects that
    indicate the current execution mode and make available the correct
    subset of the API. For this reason we have dropped
    the mutable reference from the API.

    Marked as breaking change because a dev needs to manually update the
    type in case he passed the context around to custom functions.

commit 267f8cd
Author: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
Date:   Wed Oct 29 14:03:37 2025 -0700

    chore: remove gate estimation (#17879)

    Replace complex and inaccurate "gate estimation" methods with
    potentially inefficient but simple and accurate method that makes a copy
    of the circuit then finalizes it to get the true gate count. Such
    methods should only be used in tests/debugging anyway so the extra
    copying is not an issue.

commit 66ce2c6
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 16:57:50 2025 -0400

    fix: format.sh

commit 2dd13ec
Merge: 1518bd5 c65514c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:57:24 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 27e78b0
Merge: d51bd1c c65514c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:57:21 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit bcc396a
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 20:51:07 2025 +0000

    refactor: dropping pub context mutable refs

commit d51bd1c
Merge: 322aaea 1f74833
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:36:23 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 1518bd5
Merge: 99bad53 1f74833
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:36:22 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 99bad53
Merge: 609ce30 c4fd727
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:29:49 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 322aaea
Merge: f3e41c5 c4fd727
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:29:43 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit c65514c
Merge: 1f74833 19bed87
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 20:22:01 2025 +0000

    fix: fetch commands in squash-pr.sh (#18053)

commit 19bed87
Author: ludamad <163993+ludamad@users.noreply.github.com>
Date:   Wed Oct 29 20:02:57 2025 +0000

    fix: fetch commands in squash-pr.sh

commit 1f74833
Merge: c4fd727 9d86610
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 19:52:53 2025 +0000

    refactor!: renaming `#[internal]` as `#[only_self]` + updated tests (#17958)

    Closes
    https://linear.app/aztec-labs/issue/F-20/rename-internal-to-something-else-eg-externalprivate-only-self

    We want for internal to mean the same thing as in Solidity where
    internal function can be called only from the same contract and is also
    inlined (EVM JUMP opcode and not EVM CALL). The original implementation
    of our `#[internal]` macro also results in the function being callable
    only from the same contract but it results in a different call (hence it
    doesn't map to EVM JUMP). This is very confusing hence I am doing the
    rename in this PR.

    When checking whether the `#[only_self]` is tested I stumbled upon old
    e2e tests doing that. Instead of updating them decided to move them over
    to Noir.

    A true `#[internal]` will be introduced in a followup PR.

commit f3e41c5
Merge: d9e2913 6cb98cf
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:29:45 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 609ce30
Merge: 64a93f8 6cb98cf
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:29:41 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 9d86610
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 19:29:31 2025 +0000

    refactor: renaming #[internal] as #[only_self]

commit 6cb98cf
Merge: 201c61b e842bf1
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 15:28:16 2025 -0400

    chore: only run ASAN tests on non-tag CI runs (#18044)

commit c4fd727
Merge: e82ae5b 21f14ae
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 19:26:40 2025 +0000

    chore: fix attestation gathering alerts (#18040)

commit d9e2913
Merge: e19549e 201c61b
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:19:00 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 64a93f8
Merge: e011fe7 201c61b
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:18:37 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit e82ae5b
Merge: 6cb98cf f499360
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 19:14:36 2025 +0000

    fix: backport_to_staging.sh (#18066)

commit e19549e
Merge: dd5c104 ff7090f
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:09:53 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit e011fe7
Merge: 2d7dc9b ff7090f
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:09:48 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit f499360
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 15:03:46 2025 -0400

    fix: backport_to_staging.sh

commit 201c61b
Merge: ff7090f e55a877
Author: josh crites <jc@joshcrites.com>
Date:   Wed Oct 29 18:42:01 2025 +0000

    fix(docs): Improve nightly docs release workflow to check for published GitHub releases (#18052)

    adds a check that the latest nightly release was published before
    updating the docs

commit e55a877
Author: critesjosh <18372439+critesjosh@users.noreply.github.com>
Date:   Wed Oct 29 18:41:33 2025 +0000

    fix(docs): Improve nightly docs release workflow to check for published GitHub releases

    adds a check that the latest nightly release was published before updating the docs

    Co-authored-by: Josh Crites <jc@joshcrites.com>

commit ff7090f
Merge: 8ac5056 53e048f
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 18:31:22 2025 +0000

    refactor!: introducing `ContractSelf` (#17884)

    Closes
    https://linear.app/aztec-labs/issue/F-21/implement-the-self-pattern

    Implementing `ContractSelf` that is injected to all the external
    functions as `self`. In this PR I do minimal initial implementation and
    for this reason the implementation of `ContractSelf` doesn't handle
    much.

    I wrote quite detailed migration notes that should make it clear what
    this PR achieves if it's not already clear from the issue and this
    description.

    The juicy bits are in `aztec-nr` dir and the changes to contracts are
    just repetitive callsite updates.

commit 53e048f
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 18:24:35 2025 +0000

    refactor: introducing ContractSelf

commit dd5c104
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 15:21:50 2025 -0300

    fix: Check if slot is taken after proposer check in sequencer (#18051)

    Otherwise we would continuously warn that we cant propose since the slot
    was taken by someone else. This check needs to happen AFTER the proposer
    check passes.

commit 6be1187
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 18:10:54 2025 +0000

    chore: disable proof submission in fisherman networks

commit 8323b70
Merge: bdb3c85 8ac5056
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 17:55:43 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 2d7dc9b
Merge: a079c58 8ac5056
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 17:55:31 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 8ac5056
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 13:54:04 2025 -0400

    chore(ci): reduce azure dependency for helm install (#18056)

commit a079c58
Author: Jonathan Hao <jonathanpohsianghao@gmail.com>
Date:   Wed Oct 29 17:40:24 2025 +0000

    fix: add proper error handling for invalid short hash in VK test script (#18055)
    - Fixes silent failure when the pinned short hash is invalid in the VK
    test script
    - Adds explicit error checking for curl download and tar extraction
    - Provides clear error messages to help diagnose issues
    The script was failing silently when the pinned short hash was invalid
    because:
    1. The `curl | tar` pipeline with `&>/dev/null` suppressed all error
    messages
    2. No error checking was performed on the curl command
    3. Pipeline exit status only reflected tar, not curl failures

    This made it very difficult to diagnose why the script was failing when
    the S3 artifact didn't exist.
    - Split curl and tar into separate operations with individual error
    checking
    - Added descriptive error messages that indicate the likely cause
    (invalid hash)
    - Removed silent output redirection to allow visibility into failures
    - Added progress messages during download and extraction

    Co-authored-by: Claude <noreply@anthropic.com>

commit 70c4a3d
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 11:59:50 2025 -0400

    chore(bb): remove some is_curve checks (#18037)

    Co-authored-by: Aztec Bot <49558828+AztecBot@users.noreply.github.com>

commit bdb3c85
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 12:56:30 2025 -0300

    fix: Enforce max uncompressed size for p2p messages (#18048)

    See https://eips.ethereum.org/EIPS/eip-706#avoiding-dos-attacks

    Fixes A-209

commit 29dd84e
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 15:46:27 2025 +0000

    feat: Implement PairingPoints tagging mechanism (#17988)

    This PR implements a simple tagging mechanism for PairingPoints. We
    leverage this mechanism to be sure that when a ProverInstance is built
    from a builder all the PairingPoints that have been constructed in the
    builder have been aggregated into one (we always return a single pairing
    point) and the aggregated point has been set to public.

    Closes AztecProtocol/barretenberg#1571

commit 30d3d1b
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 10:08:35 2025 -0300

    fix: Ignore duplicate p2p messages after validation (#18034)

    Today we have 3 deduplication mechanisms for messages:

    1. The `fastMsgId` cache, where gossipsub deduplicates messages based on
    a hash computed over the compressed message buffer:

    ```ts
    export function fastMsgIdFn(rpcMsg: RPC.Message): string {
      if (rpcMsg.data) {
        return xxhash.h64Raw(rpcMsg.data, h64Seed).toString(16);
      }
      return '0000000000000000';
    }
    ```

    2. The `msgId` cache, where gossipsub deduplicates messages based on a
    hash computed over the topic and the decompressed message buffer:

    ```ts
    export function getMsgIdFn(message: Message) {
      const { topic } = message;

      const vec = [Buffer.from(topic), message.data];
      return sha256(Buffer.concat(vec)).subarray(0, 20);
    }
    ```

    3. The `msgIdSeenValidators` we manually implement in `LibP2PService`,
    where we deduplicate based on the `msgId` again (**not** using the
    custom `p2pMessageIdentifier` from `Gossipable`), but with a larger
    cache, based on capacity instead of TTL:

    ```ts
        const validator = topicType ? this.msgIdSeenValidators[topicType] : undefined;

        if (!validator || !validator.addMessage(msgId)) {
          this.instrumentation.incMessagePrevalidationStatus(false, topicType);
          this.node.services.pubsub.reportMessageValidationResult(msgId, source.toString(), TopicValidatorResult.Ignore);
          return { result: false, topicType };
        }
    ```

    All of these deduplications run **after** any validation is done. This
    PR adds an additional check for duplicates after validation, where we
    deduplicate against the attestation and tx pools, using the object
    identifiers:

    ```ts
      const validationFunc: () => Promise<ReceivedMessageValidationResult<BlockProposal>> = async () => {
          const block = BlockProposal.fromBuffer(payloadData);
          const isValid = await this.validateBlockProposal(source, block);
          const exists = isValid && (await this.mempools.attestationPool!.hasBlockProposal(block));

          this.logger.trace(`Validate propagated block proposal`, {
            isValid,
            exists,
            [Attributes.SLOT_NUMBER]: block.payload.header.slotNumber.toString(),
            [Attributes.P2P_ID]: source.toString(),
          });

          if (!isValid) {
            return { result: TopicValidatorResult.Reject };
          } else if (exists) {
            return { result: TopicValidatorResult.Ignore, obj: block };
          } else {
            return { result: TopicValidatorResult.Accept, obj: block };
          }
        };
    ```

    Returning `Ignore` to gossipsub causes it to delete the message from its
    `mcache` (but not from its `seenCache`) without penalizing the sender,
    and instructs it to not re-broadcast the message.

    Note that we cannot rely on the identifiers before validation since they
    could be forged: eg an attacker could pick up an identifier for a valid
    message, change its data with garbage, and forward it so it fails
    validation. When the real message is received afterwards, it gets
    rejected because it had previously failed. We need to run these id-based
    deduplications after validation so we know that the identifier
    corresponds to the payload.

    This change prevents a malicious message originator from slightly
    modifying part of its message and broadcasting it across the network
    repeatedly, causing it to be re-processed and re-broadcasted. Eg a
    malicious attester could rely on non-deterministic ecdsa signatures to
    produce different valid signatures for the same attestation and
    broadcast them all. This change would only accept the first attestation
    and reject all others.

    Fixes A-206

commit 292c16b
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 11:16:44 2025 +0000

    chore: copy bb-avm into the release-image

commit e842bf1
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 12:40:49 2025 +0000

    chore: only run ASAN tests on non-tag CI runs

commit 21f14ae
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 10:41:47 2025 +0000

    chore: fix attestation gathering alerts

commit e5d3c62
Merge: c38fa23 d22a23e
Author: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
Date:   Wed Oct 29 10:02:55 2025 +0000

    feat: merge-train/barretenberg (#18038)

    See
    [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md).
    This is a merge-train.
federicobarbacovi added a commit that referenced this pull request Oct 30, 2025
@federicobarbacovi
Squash commit of fb/ec_operation_audit_1 to test
f4d481e 
commit 5168715
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 09:58:17 2025 +0000

    Update vks, minor changes

commit 45acdbf
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 16:28:07 2025 +0000

    Address comments

commit 8a9cff3
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 12:54:37 2025 +0000

    Restructuring

commit bad1c0e
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 12:02:16 2025 +0000

    Refactoring

commit d9b0dfd
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Tue Oct 28 15:02:53 2025 +0000

    Minor change + add assertion constant predicate is true

commit 5dc6f08
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Tue Oct 28 09:59:40 2025 +0000

    Small cleanup

commit 7d41783
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Mon Oct 27 15:41:43 2025 +0000

    Refactoring

commit 1a324e9
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 09:40:15 2025 +0000

    fix: Fix vk test (#18057)

    Update test vk to use `bb-chonk`. Forced update of vks to avoid breaking
    changes. No change to circuits (same vks, just different upload target)

commit d9d6ac8
Merge: becf9a5 6fe8217
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 02:43:00 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 6fe8217
Merge: c8ef782 51c0086
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 22:41:37 2025 -0400

    fix: revert squash_pr.sh (#18082)

commit 51c0086
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 22:41:13 2025 -0400

    fix: revert squash_pr.sh

    I had introduced issues

commit becf9a5
Merge: 7440370 c8ef782
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 00:51:15 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit c8ef782
Merge: 328d4a9 ae2ec47
Author: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
Date:   Thu Oct 30 00:08:53 2025 +0000

    chore: remappings to avoid nasty lib (#18004)

    Figured out that we can use profile based remappings in foundry to
    insert different versions of the blob library based on whether we are
    executing as part of a test or for deployment.

    By default we will now be using a bloblib for testing. For deployments,
    we will need to use `FOUNDRY_PROFILE=deployment` to compile without the
    cheatcodes.

commit 7440370
Merge: 15a9796 328d4a9
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 00:00:24 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 15a9796
Merge: 29cf60c 12ba368
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:56:28 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 29cf60c
Merge: 5bb2938 97cd64c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:47:55 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 5bb2938
Merge: 62a00e8 d07a493
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:42:00 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 328d4a9
Merge: 12ba368 666f2ca
Author: spypsy <spypsy@users.noreply.github.com>
Date:   Wed Oct 29 23:25:59 2025 +0000

    fix: no new blocks alerting (#18063)

    - Alert when no block data can be loaded by our metrics dashboard
    - bonus step: use `increase` which handles missing / weird (reset) data
    more robustly

commit 666f2ca
Author: spypsy <6403450+spypsy@users.noreply.github.com>
Date:   Wed Oct 29 23:25:36 2025 +0000

    fix: no new blocks alerting

    - Alert when no block data can be loaded by our metrics dashboard
    - bonus step: use `increase` which handles missing / weird (reset) data more robustly

commit ae2ec47
Author: LHerskind <16536249+LHerskind@users.noreply.github.com>
Date:   Wed Oct 29 23:15:05 2025 +0000

    chore: remappings to avoid nasty lib

commit 12ba368
Merge: 97cd64c 292c16b
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 23:13:16 2025 +0000

    chore: copy bb-avm into the release-image (#18042)

    Copy `bb-avm` instead of `bb` into the release image

commit 97cd64c
Merge: d07a493 6be1187
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 23:12:31 2025 +0000

    chore: disable proof submission in fisherman networks (#18060)

    This PR flips the `PROVER_NODE_DISABLE_PROOF_PUBLISH` (disabling txs)
    for fisherman deployments

commit d07a493
Merge: c83136d e9abfaa
Author: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
Date:   Wed Oct 29 23:02:38 2025 +0000

    feat: merge-train/spartan (#18045)

    BEGIN_COMMIT_OVERRIDE
    fix: Ignore duplicate p2p messages after validation (#18034)
    fix: Enforce max uncompressed size for p2p messages (#18048)
    fix: Check if slot is taken after proposer check in sequencer (#18051)
    END_COMMIT_OVERRIDE

commit 62a00e8
Merge: 267f8cd c83136d
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 21:56:43 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit e9abfaa
Merge: 27e78b0 c83136d
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 21:56:38 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit c83136d
Merge: c65514c bcc396a
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 21:17:05 2025 +0000

    refactor!: dropping pub context mutable refs (#17997)

    Closes
    https://linear.app/aztec-labs/issue/F-110/remote-mut-refs-to-public-context

    `PrivateContext` generally needs to be passed as a mutable reference to
    functions because it does actually hold state
    we're mutating. This is not the case for `PublicContext`, or
    `UtilityContext` - these are just marker objects that
    indicate the current execution mode and make available the correct
    subset of the API. For this reason we have dropped
    the mutable reference from the API.

    Marked as breaking change because a dev needs to manually update the
    type in case he passed the context around to custom functions.

commit 267f8cd
Author: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
Date:   Wed Oct 29 14:03:37 2025 -0700

    chore: remove gate estimation (#17879)

    Replace complex and inaccurate "gate estimation" methods with
    potentially inefficient but simple and accurate method that makes a copy
    of the circuit then finalizes it to get the true gate count. Such
    methods should only be used in tests/debugging anyway so the extra
    copying is not an issue.

commit 66ce2c6
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 16:57:50 2025 -0400

    fix: format.sh

commit 2dd13ec
Merge: 1518bd5 c65514c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:57:24 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 27e78b0
Merge: d51bd1c c65514c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:57:21 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit bcc396a
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 20:51:07 2025 +0000

    refactor: dropping pub context mutable refs

commit d51bd1c
Merge: 322aaea 1f74833
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:36:23 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 1518bd5
Merge: 99bad53 1f74833
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:36:22 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 99bad53
Merge: 609ce30 c4fd727
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:29:49 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 322aaea
Merge: f3e41c5 c4fd727
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:29:43 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit c65514c
Merge: 1f74833 19bed87
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 20:22:01 2025 +0000

    fix: fetch commands in squash-pr.sh (#18053)

commit 19bed87
Author: ludamad <163993+ludamad@users.noreply.github.com>
Date:   Wed Oct 29 20:02:57 2025 +0000

    fix: fetch commands in squash-pr.sh

commit 1f74833
Merge: c4fd727 9d86610
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 19:52:53 2025 +0000

    refactor!: renaming `#[internal]` as `#[only_self]` + updated tests (#17958)

    Closes
    https://linear.app/aztec-labs/issue/F-20/rename-internal-to-something-else-eg-externalprivate-only-self

    We want for internal to mean the same thing as in Solidity where
    internal function can be called only from the same contract and is also
    inlined (EVM JUMP opcode and not EVM CALL). The original implementation
    of our `#[internal]` macro also results in the function being callable
    only from the same contract but it results in a different call (hence it
    doesn't map to EVM JUMP). This is very confusing hence I am doing the
    rename in this PR.

    When checking whether the `#[only_self]` is tested I stumbled upon old
    e2e tests doing that. Instead of updating them decided to move them over
    to Noir.

    A true `#[internal]` will be introduced in a followup PR.

commit f3e41c5
Merge: d9e2913 6cb98cf
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:29:45 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 609ce30
Merge: 64a93f8 6cb98cf
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:29:41 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 9d86610
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 19:29:31 2025 +0000

    refactor: renaming #[internal] as #[only_self]

commit 6cb98cf
Merge: 201c61b e842bf1
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 15:28:16 2025 -0400

    chore: only run ASAN tests on non-tag CI runs (#18044)

commit c4fd727
Merge: e82ae5b 21f14ae
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 19:26:40 2025 +0000

    chore: fix attestation gathering alerts (#18040)

commit d9e2913
Merge: e19549e 201c61b
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:19:00 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 64a93f8
Merge: e011fe7 201c61b
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:18:37 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit e82ae5b
Merge: 6cb98cf f499360
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 19:14:36 2025 +0000

    fix: backport_to_staging.sh (#18066)

commit e19549e
Merge: dd5c104 ff7090f
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:09:53 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit e011fe7
Merge: 2d7dc9b ff7090f
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:09:48 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit f499360
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 15:03:46 2025 -0400

    fix: backport_to_staging.sh

commit 201c61b
Merge: ff7090f e55a877
Author: josh crites <jc@joshcrites.com>
Date:   Wed Oct 29 18:42:01 2025 +0000

    fix(docs): Improve nightly docs release workflow to check for published GitHub releases (#18052)

    adds a check that the latest nightly release was published before
    updating the docs

commit e55a877
Author: critesjosh <18372439+critesjosh@users.noreply.github.com>
Date:   Wed Oct 29 18:41:33 2025 +0000

    fix(docs): Improve nightly docs release workflow to check for published GitHub releases

    adds a check that the latest nightly release was published before updating the docs

    Co-authored-by: Josh Crites <jc@joshcrites.com>

commit ff7090f
Merge: 8ac5056 53e048f
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 18:31:22 2025 +0000

    refactor!: introducing `ContractSelf` (#17884)

    Closes
    https://linear.app/aztec-labs/issue/F-21/implement-the-self-pattern

    Implementing `ContractSelf` that is injected to all the external
    functions as `self`. In this PR I do minimal initial implementation and
    for this reason the implementation of `ContractSelf` doesn't handle
    much.

    I wrote quite detailed migration notes that should make it clear what
    this PR achieves if it's not already clear from the issue and this
    description.

    The juicy bits are in `aztec-nr` dir and the changes to contracts are
    just repetitive callsite updates.

commit 53e048f
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 18:24:35 2025 +0000

    refactor: introducing ContractSelf

commit dd5c104
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 15:21:50 2025 -0300

    fix: Check if slot is taken after proposer check in sequencer (#18051)

    Otherwise we would continuously warn that we cant propose since the slot
    was taken by someone else. This check needs to happen AFTER the proposer
    check passes.

commit 6be1187
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 18:10:54 2025 +0000

    chore: disable proof submission in fisherman networks

commit 8323b70
Merge: bdb3c85 8ac5056
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 17:55:43 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 2d7dc9b
Merge: a079c58 8ac5056
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 17:55:31 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 8ac5056
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 13:54:04 2025 -0400

    chore(ci): reduce azure dependency for helm install (#18056)

commit a079c58
Author: Jonathan Hao <jonathanpohsianghao@gmail.com>
Date:   Wed Oct 29 17:40:24 2025 +0000

    fix: add proper error handling for invalid short hash in VK test script (#18055)
    - Fixes silent failure when the pinned short hash is invalid in the VK
    test script
    - Adds explicit error checking for curl download and tar extraction
    - Provides clear error messages to help diagnose issues
    The script was failing silently when the pinned short hash was invalid
    because:
    1. The `curl | tar` pipeline with `&>/dev/null` suppressed all error
    messages
    2. No error checking was performed on the curl command
    3. Pipeline exit status only reflected tar, not curl failures

    This made it very difficult to diagnose why the script was failing when
    the S3 artifact didn't exist.
    - Split curl and tar into separate operations with individual error
    checking
    - Added descriptive error messages that indicate the likely cause
    (invalid hash)
    - Removed silent output redirection to allow visibility into failures
    - Added progress messages during download and extraction

    Co-authored-by: Claude <noreply@anthropic.com>

commit 70c4a3d
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 11:59:50 2025 -0400

    chore(bb): remove some is_curve checks (#18037)

    Co-authored-by: Aztec Bot <49558828+AztecBot@users.noreply.github.com>

commit bdb3c85
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 12:56:30 2025 -0300

    fix: Enforce max uncompressed size for p2p messages (#18048)

    See https://eips.ethereum.org/EIPS/eip-706#avoiding-dos-attacks

    Fixes A-209

commit 29dd84e
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 15:46:27 2025 +0000

    feat: Implement PairingPoints tagging mechanism (#17988)

    This PR implements a simple tagging mechanism for PairingPoints. We
    leverage this mechanism to be sure that when a ProverInstance is built
    from a builder all the PairingPoints that have been constructed in the
    builder have been aggregated into one (we always return a single pairing
    point) and the aggregated point has been set to public.

    Closes AztecProtocol/barretenberg#1571

commit 30d3d1b
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 10:08:35 2025 -0300

    fix: Ignore duplicate p2p messages after validation (#18034)

    Today we have 3 deduplication mechanisms for messages:

    1. The `fastMsgId` cache, where gossipsub deduplicates messages based on
    a hash computed over the compressed message buffer:

    ```ts
    export function fastMsgIdFn(rpcMsg: RPC.Message): string {
      if (rpcMsg.data) {
        return xxhash.h64Raw(rpcMsg.data, h64Seed).toString(16);
      }
      return '0000000000000000';
    }
    ```

    2. The `msgId` cache, where gossipsub deduplicates messages based on a
    hash computed over the topic and the decompressed message buffer:

    ```ts
    export function getMsgIdFn(message: Message) {
      const { topic } = message;

      const vec = [Buffer.from(topic), message.data];
      return sha256(Buffer.concat(vec)).subarray(0, 20);
    }
    ```

    3. The `msgIdSeenValidators` we manually implement in `LibP2PService`,
    where we deduplicate based on the `msgId` again (**not** using the
    custom `p2pMessageIdentifier` from `Gossipable`), but with a larger
    cache, based on capacity instead of TTL:

    ```ts
        const validator = topicType ? this.msgIdSeenValidators[topicType] : undefined;

        if (!validator || !validator.addMessage(msgId)) {
          this.instrumentation.incMessagePrevalidationStatus(false, topicType);
          this.node.services.pubsub.reportMessageValidationResult(msgId, source.toString(), TopicValidatorResult.Ignore);
          return { result: false, topicType };
        }
    ```

    All of these deduplications run **after** any validation is done. This
    PR adds an additional check for duplicates after validation, where we
    deduplicate against the attestation and tx pools, using the object
    identifiers:

    ```ts
      const validationFunc: () => Promise<ReceivedMessageValidationResult<BlockProposal>> = async () => {
          const block = BlockProposal.fromBuffer(payloadData);
          const isValid = await this.validateBlockProposal(source, block);
          const exists = isValid && (await this.mempools.attestationPool!.hasBlockProposal(block));

          this.logger.trace(`Validate propagated block proposal`, {
            isValid,
            exists,
            [Attributes.SLOT_NUMBER]: block.payload.header.slotNumber.toString(),
            [Attributes.P2P_ID]: source.toString(),
          });

          if (!isValid) {
            return { result: TopicValidatorResult.Reject };
          } else if (exists) {
            return { result: TopicValidatorResult.Ignore, obj: block };
          } else {
            return { result: TopicValidatorResult.Accept, obj: block };
          }
        };
    ```

    Returning `Ignore` to gossipsub causes it to delete the message from its
    `mcache` (but not from its `seenCache`) without penalizing the sender,
    and instructs it to not re-broadcast the message.

    Note that we cannot rely on the identifiers before validation since they
    could be forged: eg an attacker could pick up an identifier for a valid
    message, change its data with garbage, and forward it so it fails
    validation. When the real message is received afterwards, it gets
    rejected because it had previously failed. We need to run these id-based
    deduplications after validation so we know that the identifier
    corresponds to the payload.

    This change prevents a malicious message originator from slightly
    modifying part of its message and broadcasting it across the network
    repeatedly, causing it to be re-processed and re-broadcasted. Eg a
    malicious attester could rely on non-deterministic ecdsa signatures to
    produce different valid signatures for the same attestation and
    broadcast them all. This change would only accept the first attestation
    and reject all others.

    Fixes A-206

commit 292c16b
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 11:16:44 2025 +0000

    chore: copy bb-avm into the release-image

commit e842bf1
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 12:40:49 2025 +0000

    chore: only run ASAN tests on non-tag CI runs

commit 21f14ae
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 10:41:47 2025 +0000

    chore: fix attestation gathering alerts

commit e5d3c62
Merge: c38fa23 d22a23e
Author: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
Date:   Wed Oct 29 10:02:55 2025 +0000

    feat: merge-train/barretenberg (#18038)

    See
    [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md).
    This is a merge-train.
federicobarbacovi added a commit that referenced this pull request Oct 30, 2025
@federicobarbacovi
Squashed commit of fb/ec_operations_audit_1
71cd26d 
commit 7325e5d
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 12:14:37 2025 +0000

    Update vks

commit a1d04e5
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 12:07:30 2025 +0000

    Restore cast to boolean

commit 6685004
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 11:09:46 2025 +0000

    Fix changes

commit 5168715
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 09:58:17 2025 +0000

    Update vks, minor changes

commit 45acdbf
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 16:28:07 2025 +0000

    Address comments

commit 8a9cff3
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 12:54:37 2025 +0000

    Restructuring

commit bad1c0e
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 12:02:16 2025 +0000

    Refactoring

commit d9b0dfd
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Tue Oct 28 15:02:53 2025 +0000

    Minor change + add assertion constant predicate is true

commit 5dc6f08
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Tue Oct 28 09:59:40 2025 +0000

    Small cleanup

commit 7d41783
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Mon Oct 27 15:41:43 2025 +0000

    Refactoring

commit 1a324e9
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Thu Oct 30 09:40:15 2025 +0000

    fix: Fix vk test (#18057)

    Update test vk to use `bb-chonk`. Forced update of vks to avoid breaking
    changes. No change to circuits (same vks, just different upload target)

commit d9d6ac8
Merge: becf9a5 6fe8217
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 02:43:00 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 6fe8217
Merge: c8ef782 51c0086
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 22:41:37 2025 -0400

    fix: revert squash_pr.sh (#18082)

commit 51c0086
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 22:41:13 2025 -0400

    fix: revert squash_pr.sh

    I had introduced issues

commit becf9a5
Merge: 7440370 c8ef782
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 00:51:15 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit c8ef782
Merge: 328d4a9 ae2ec47
Author: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
Date:   Thu Oct 30 00:08:53 2025 +0000

    chore: remappings to avoid nasty lib (#18004)

    Figured out that we can use profile based remappings in foundry to
    insert different versions of the blob library based on whether we are
    executing as part of a test or for deployment.

    By default we will now be using a bloblib for testing. For deployments,
    we will need to use `FOUNDRY_PROFILE=deployment` to compile without the
    cheatcodes.

commit 7440370
Merge: 15a9796 328d4a9
Author: AztecBot <tech@aztecprotocol.com>
Date:   Thu Oct 30 00:00:24 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 15a9796
Merge: 29cf60c 12ba368
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:56:28 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 29cf60c
Merge: 5bb2938 97cd64c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:47:55 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 5bb2938
Merge: 62a00e8 d07a493
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 23:42:00 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 328d4a9
Merge: 12ba368 666f2ca
Author: spypsy <spypsy@users.noreply.github.com>
Date:   Wed Oct 29 23:25:59 2025 +0000

    fix: no new blocks alerting (#18063)

    - Alert when no block data can be loaded by our metrics dashboard
    - bonus step: use `increase` which handles missing / weird (reset) data
    more robustly

commit 666f2ca
Author: spypsy <6403450+spypsy@users.noreply.github.com>
Date:   Wed Oct 29 23:25:36 2025 +0000

    fix: no new blocks alerting

    - Alert when no block data can be loaded by our metrics dashboard
    - bonus step: use `increase` which handles missing / weird (reset) data more robustly

commit ae2ec47
Author: LHerskind <16536249+LHerskind@users.noreply.github.com>
Date:   Wed Oct 29 23:15:05 2025 +0000

    chore: remappings to avoid nasty lib

commit 12ba368
Merge: 97cd64c 292c16b
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 23:13:16 2025 +0000

    chore: copy bb-avm into the release-image (#18042)

    Copy `bb-avm` instead of `bb` into the release image

commit 97cd64c
Merge: d07a493 6be1187
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 23:12:31 2025 +0000

    chore: disable proof submission in fisherman networks (#18060)

    This PR flips the `PROVER_NODE_DISABLE_PROOF_PUBLISH` (disabling txs)
    for fisherman deployments

commit d07a493
Merge: c83136d e9abfaa
Author: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
Date:   Wed Oct 29 23:02:38 2025 +0000

    feat: merge-train/spartan (#18045)

    BEGIN_COMMIT_OVERRIDE
    fix: Ignore duplicate p2p messages after validation (#18034)
    fix: Enforce max uncompressed size for p2p messages (#18048)
    fix: Check if slot is taken after proposer check in sequencer (#18051)
    END_COMMIT_OVERRIDE

commit 62a00e8
Merge: 267f8cd c83136d
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 21:56:43 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit e9abfaa
Merge: 27e78b0 c83136d
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 21:56:38 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit c83136d
Merge: c65514c bcc396a
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 21:17:05 2025 +0000

    refactor!: dropping pub context mutable refs (#17997)

    Closes
    https://linear.app/aztec-labs/issue/F-110/remote-mut-refs-to-public-context

    `PrivateContext` generally needs to be passed as a mutable reference to
    functions because it does actually hold state
    we're mutating. This is not the case for `PublicContext`, or
    `UtilityContext` - these are just marker objects that
    indicate the current execution mode and make available the correct
    subset of the API. For this reason we have dropped
    the mutable reference from the API.

    Marked as breaking change because a dev needs to manually update the
    type in case he passed the context around to custom functions.

commit 267f8cd
Author: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
Date:   Wed Oct 29 14:03:37 2025 -0700

    chore: remove gate estimation (#17879)

    Replace complex and inaccurate "gate estimation" methods with
    potentially inefficient but simple and accurate method that makes a copy
    of the circuit then finalizes it to get the true gate count. Such
    methods should only be used in tests/debugging anyway so the extra
    copying is not an issue.

commit 66ce2c6
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 16:57:50 2025 -0400

    fix: format.sh

commit 2dd13ec
Merge: 1518bd5 c65514c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:57:24 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 27e78b0
Merge: d51bd1c c65514c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:57:21 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit bcc396a
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 20:51:07 2025 +0000

    refactor: dropping pub context mutable refs

commit d51bd1c
Merge: 322aaea 1f74833
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:36:23 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 1518bd5
Merge: 99bad53 1f74833
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:36:22 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 99bad53
Merge: 609ce30 c4fd727
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:29:49 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 322aaea
Merge: f3e41c5 c4fd727
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 20:29:43 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit c65514c
Merge: 1f74833 19bed87
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 20:22:01 2025 +0000

    fix: fetch commands in squash-pr.sh (#18053)

commit 19bed87
Author: ludamad <163993+ludamad@users.noreply.github.com>
Date:   Wed Oct 29 20:02:57 2025 +0000

    fix: fetch commands in squash-pr.sh

commit 1f74833
Merge: c4fd727 9d86610
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 19:52:53 2025 +0000

    refactor!: renaming `#[internal]` as `#[only_self]` + updated tests (#17958)

    Closes
    https://linear.app/aztec-labs/issue/F-20/rename-internal-to-something-else-eg-externalprivate-only-self

    We want for internal to mean the same thing as in Solidity where
    internal function can be called only from the same contract and is also
    inlined (EVM JUMP opcode and not EVM CALL). The original implementation
    of our `#[internal]` macro also results in the function being callable
    only from the same contract but it results in a different call (hence it
    doesn't map to EVM JUMP). This is very confusing hence I am doing the
    rename in this PR.

    When checking whether the `#[only_self]` is tested I stumbled upon old
    e2e tests doing that. Instead of updating them decided to move them over
    to Noir.

    A true `#[internal]` will be introduced in a followup PR.

commit f3e41c5
Merge: d9e2913 6cb98cf
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:29:45 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 609ce30
Merge: 64a93f8 6cb98cf
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:29:41 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 9d86610
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 19:29:31 2025 +0000

    refactor: renaming #[internal] as #[only_self]

commit 6cb98cf
Merge: 201c61b e842bf1
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 15:28:16 2025 -0400

    chore: only run ASAN tests on non-tag CI runs (#18044)

commit c4fd727
Merge: e82ae5b 21f14ae
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 19:26:40 2025 +0000

    chore: fix attestation gathering alerts (#18040)

commit d9e2913
Merge: e19549e 201c61b
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:19:00 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 64a93f8
Merge: e011fe7 201c61b
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:18:37 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit e82ae5b
Merge: 6cb98cf f499360
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 19:14:36 2025 +0000

    fix: backport_to_staging.sh (#18066)

commit e19549e
Merge: dd5c104 ff7090f
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:09:53 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit e011fe7
Merge: 2d7dc9b ff7090f
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 19:09:48 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit f499360
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 15:03:46 2025 -0400

    fix: backport_to_staging.sh

commit 201c61b
Merge: ff7090f e55a877
Author: josh crites <jc@joshcrites.com>
Date:   Wed Oct 29 18:42:01 2025 +0000

    fix(docs): Improve nightly docs release workflow to check for published GitHub releases (#18052)

    adds a check that the latest nightly release was published before
    updating the docs

commit e55a877
Author: critesjosh <18372439+critesjosh@users.noreply.github.com>
Date:   Wed Oct 29 18:41:33 2025 +0000

    fix(docs): Improve nightly docs release workflow to check for published GitHub releases

    adds a check that the latest nightly release was published before updating the docs

    Co-authored-by: Josh Crites <jc@joshcrites.com>

commit ff7090f
Merge: 8ac5056 53e048f
Author: Jan Beneš <janbenes1234@gmail.com>
Date:   Wed Oct 29 18:31:22 2025 +0000

    refactor!: introducing `ContractSelf` (#17884)

    Closes
    https://linear.app/aztec-labs/issue/F-21/implement-the-self-pattern

    Implementing `ContractSelf` that is injected to all the external
    functions as `self`. In this PR I do minimal initial implementation and
    for this reason the implementation of `ContractSelf` doesn't handle
    much.

    I wrote quite detailed migration notes that should make it clear what
    this PR achieves if it's not already clear from the issue and this
    description.

    The juicy bits are in `aztec-nr` dir and the changes to contracts are
    just repetitive callsite updates.

commit 53e048f
Author: benesjan <janbenes1234@gmail.com>
Date:   Wed Oct 29 18:24:35 2025 +0000

    refactor: introducing ContractSelf

commit dd5c104
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 15:21:50 2025 -0300

    fix: Check if slot is taken after proposer check in sequencer (#18051)

    Otherwise we would continuously warn that we cant propose since the slot
    was taken by someone else. This check needs to happen AFTER the proposer
    check passes.

commit 6be1187
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 18:10:54 2025 +0000

    chore: disable proof submission in fisherman networks

commit 8323b70
Merge: bdb3c85 8ac5056
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 17:55:43 2025 +0000

    Merge branch 'next' into merge-train/spartan

commit 2d7dc9b
Merge: a079c58 8ac5056
Author: AztecBot <tech@aztecprotocol.com>
Date:   Wed Oct 29 17:55:31 2025 +0000

    Merge branch 'next' into merge-train/barretenberg

commit 8ac5056
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 13:54:04 2025 -0400

    chore(ci): reduce azure dependency for helm install (#18056)

commit a079c58
Author: Jonathan Hao <jonathanpohsianghao@gmail.com>
Date:   Wed Oct 29 17:40:24 2025 +0000

    fix: add proper error handling for invalid short hash in VK test script (#18055)
    - Fixes silent failure when the pinned short hash is invalid in the VK
    test script
    - Adds explicit error checking for curl download and tar extraction
    - Provides clear error messages to help diagnose issues
    The script was failing silently when the pinned short hash was invalid
    because:
    1. The `curl | tar` pipeline with `&>/dev/null` suppressed all error
    messages
    2. No error checking was performed on the curl command
    3. Pipeline exit status only reflected tar, not curl failures

    This made it very difficult to diagnose why the script was failing when
    the S3 artifact didn't exist.
    - Split curl and tar into separate operations with individual error
    checking
    - Added descriptive error messages that indicate the likely cause
    (invalid hash)
    - Removed silent output redirection to allow visibility into failures
    - Added progress messages during download and extraction

    Co-authored-by: Claude <noreply@anthropic.com>

commit 70c4a3d
Author: ludamad <adam.domurad@gmail.com>
Date:   Wed Oct 29 11:59:50 2025 -0400

    chore(bb): remove some is_curve checks (#18037)

    Co-authored-by: Aztec Bot <49558828+AztecBot@users.noreply.github.com>

commit bdb3c85
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 12:56:30 2025 -0300

    fix: Enforce max uncompressed size for p2p messages (#18048)

    See https://eips.ethereum.org/EIPS/eip-706#avoiding-dos-attacks

    Fixes A-209

commit 29dd84e
Author: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
Date:   Wed Oct 29 15:46:27 2025 +0000

    feat: Implement PairingPoints tagging mechanism (#17988)

    This PR implements a simple tagging mechanism for PairingPoints. We
    leverage this mechanism to be sure that when a ProverInstance is built
    from a builder all the PairingPoints that have been constructed in the
    builder have been aggregated into one (we always return a single pairing
    point) and the aggregated point has been set to public.

    Closes AztecProtocol/barretenberg#1571

commit 30d3d1b
Author: Santiago Palladino <santiago@aztecprotocol.com>
Date:   Wed Oct 29 10:08:35 2025 -0300

    fix: Ignore duplicate p2p messages after validation (#18034)

    Today we have 3 deduplication mechanisms for messages:

    1. The `fastMsgId` cache, where gossipsub deduplicates messages based on
    a hash computed over the compressed message buffer:

    ```ts
    export function fastMsgIdFn(rpcMsg: RPC.Message): string {
      if (rpcMsg.data) {
        return xxhash.h64Raw(rpcMsg.data, h64Seed).toString(16);
      }
      return '0000000000000000';
    }
    ```

    2. The `msgId` cache, where gossipsub deduplicates messages based on a
    hash computed over the topic and the decompressed message buffer:

    ```ts
    export function getMsgIdFn(message: Message) {
      const { topic } = message;

      const vec = [Buffer.from(topic), message.data];
      return sha256(Buffer.concat(vec)).subarray(0, 20);
    }
    ```

    3. The `msgIdSeenValidators` we manually implement in `LibP2PService`,
    where we deduplicate based on the `msgId` again (**not** using the
    custom `p2pMessageIdentifier` from `Gossipable`), but with a larger
    cache, based on capacity instead of TTL:

    ```ts
        const validator = topicType ? this.msgIdSeenValidators[topicType] : undefined;

        if (!validator || !validator.addMessage(msgId)) {
          this.instrumentation.incMessagePrevalidationStatus(false, topicType);
          this.node.services.pubsub.reportMessageValidationResult(msgId, source.toString(), TopicValidatorResult.Ignore);
          return { result: false, topicType };
        }
    ```

    All of these deduplications run **after** any validation is done. This
    PR adds an additional check for duplicates after validation, where we
    deduplicate against the attestation and tx pools, using the object
    identifiers:

    ```ts
      const validationFunc: () => Promise<ReceivedMessageValidationResult<BlockProposal>> = async () => {
          const block = BlockProposal.fromBuffer(payloadData);
          const isValid = await this.validateBlockProposal(source, block);
          const exists = isValid && (await this.mempools.attestationPool!.hasBlockProposal(block));

          this.logger.trace(`Validate propagated block proposal`, {
            isValid,
            exists,
            [Attributes.SLOT_NUMBER]: block.payload.header.slotNumber.toString(),
            [Attributes.P2P_ID]: source.toString(),
          });

          if (!isValid) {
            return { result: TopicValidatorResult.Reject };
          } else if (exists) {
            return { result: TopicValidatorResult.Ignore, obj: block };
          } else {
            return { result: TopicValidatorResult.Accept, obj: block };
          }
        };
    ```

    Returning `Ignore` to gossipsub causes it to delete the message from its
    `mcache` (but not from its `seenCache`) without penalizing the sender,
    and instructs it to not re-broadcast the message.

    Note that we cannot rely on the identifiers before validation since they
    could be forged: eg an attacker could pick up an identifier for a valid
    message, change its data with garbage, and forward it so it fails
    validation. When the real message is received afterwards, it gets
    rejected because it had previously failed. We need to run these id-based
    deduplications after validation so we know that the identifier
    corresponds to the payload.

    This change prevents a malicious message originator from slightly
    modifying part of its message and broadcasting it across the network
    repeatedly, causing it to be re-processed and re-broadcasted. Eg a
    malicious attester could rely on non-deterministic ecdsa signatures to
    produce different valid signatures for the same attestation and
    broadcast them all. This change would only accept the first attestation
    and reject all others.

    Fixes A-206

commit 292c16b
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 11:16:44 2025 +0000

    chore: copy bb-avm into the release-image

commit e842bf1
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 12:40:49 2025 +0000

    chore: only run ASAN tests on non-tag CI runs

commit 21f14ae
Author: Alex Gherghisan <alexghr@users.noreply.github.com>
Date:   Wed Oct 29 10:41:47 2025 +0000

    chore: fix attestation gathering alerts

commit e5d3c62
Merge: c38fa23 d22a23e
Author: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
Date:   Wed Oct 29 10:02:55 2025 +0000

    feat: merge-train/barretenberg (#18038)

    See
    [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md).
    This is a merge-train.
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2025
@AztecBot
feat: merge-train/barretenberg (#18083)
8f68aa8 
BEGIN_COMMIT_OVERRIDE
fix: Fix vk test (#18057)
END_COMMIT_OVERRIDE
ludamad pushed a commit that referenced this pull request Dec 16, 2025
@federicobarbacovi @ludamad
fix: Fix vk test (#18057)
6314c27 
Update test vk to use `bb-chonk`. Forced update of vks to avoid breaking
changes. No change to circuits (same vks, just different upload target)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnathan79717 johnathan79717 johnathan79717 approved these changes

@ludamad ludamad Awaiting requested review from ludamad

Assignees

@federicobarbacovi federicobarbacovi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@federicobarbacovi @johnathan79717