Skip to content

chore: only run ASAN tests on non-tag CI runs #18044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 1 commit into from
Oct 29, 2025
Merged

chore: only run ASAN tests on non-tag CI runs #18044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions barretenberg/cpp/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,19 +256,23 @@ function test_cmds {
if [ "$(arch)" == "amd64" ] && [ "$CI" -eq 1 ]; then
# We only want to sanity check that we haven't broken wasm ecc in merge queue.
echo "$hash barretenberg/cpp/scripts/wasmtime.sh barretenberg/cpp/build-wasm-threads/bin/ecc_tests"
# Mostly arbitrary set that touches lots of the code.
declare -A asan_tests=(
["commitment_schemes_recursion_tests"]="IPARecursiveTests.AccumulationAndFullRecursiveVerifier"
["chonk_tests"]="ChonkTests.Basic"
["ultra_honk_tests"]="MegaHonkTests/0.Basic"
["dsl_tests"]="AcirHonkRecursionConstraint/1.TestBasicDoubleHonkRecursionConstraints"
)
# If in amd64 CI, iterate asan_tests, creating a gtest invocation for each.
for bin_name in "${!asan_tests[@]}"; do
local filter=${asan_tests[$bin_name]}
local prefix="$hash:CPUS=4:MEM=8g"
echo -e "$prefix barretenberg/cpp/build-asan-fast/bin/$bin_name --gtest_filter=$filter"
done

# only run ASAN tests if not building a release
if ! semver check "$REF_NAME"; then

@alexghr alexghr Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change and it matches what's being built. The rest of the diff is just indentation

# Mostly arbitrary set that touches lots of the code.
declare -A asan_tests=(
["commitment_schemes_recursion_tests"]="IPARecursiveTests.AccumulationAndFullRecursiveVerifier"
["chonk_tests"]="ChonkTests.Basic"
["ultra_honk_tests"]="MegaHonkTests/0.Basic"
["dsl_tests"]="AcirHonkRecursionConstraint/1.TestBasicDoubleHonkRecursionConstraints"
)
# If in amd64 CI, iterate asan_tests, creating a gtest invocation for each.
for bin_name in "${!asan_tests[@]}"; do
local filter=${asan_tests[$bin_name]}
local prefix="$hash:CPUS=4:MEM=8g"
echo -e "$prefix barretenberg/cpp/build-asan-fast/bin/$bin_name --gtest_filter=$filter"
done
fi
fi

# Run the SMT compatibility tests
Expand Down
Loading