Merged
Conversation
### 🧾 Audit Context Audit of ROM/RAM witness generation and constraints in `stdlib_circuit`. ### 🛠️ Changes Made Revamped testing. ### ✅ Checklist - ✅ Audited all methods of the relevant module/class - ✅ Audited the interface of the module/class with other (relevant) components - ✅ Documented existing functionality and any changes made (as per Doxygen requirements) - [ ] Resolved and/or closed all issues/TODOs pertaining to the audited files - [ ] Confirmed and documented any security or other issues found (if applicable) - [ ] Verified that tests cover all critical paths (and added tests if necessary) - [ ] Updated audit tracking for the files audited (check the start of each file you audited) ### 📌 Notes for Reviewers No changes to the functionality either of witness generation or constraints. Added better testing for ROM/RAM and more thorough documentation for things that confused me. We should decide how we want to handle uninitialized entries. I would prefer to throw an error if any entry was uninitialized at the time of processing. --------- Co-authored-by: notnotraju <raju@aztec-labs.com>
This PR implements a simple tagging mechanism for PairingPoints. We leverage this mechanism to be sure that when a ProverInstance is built from a builder all the PairingPoints that have been constructed in the builder have been aggregated into one (we always return a single pairing point) and the aggregated point has been set to public. Closes AztecProtocol/barretenberg#1571
federicobarbacovi
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
Co-authored-by: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
…pt (#18055) ## Summary - Fixes silent failure when the pinned short hash is invalid in the VK test script - Adds explicit error checking for curl download and tar extraction - Provides clear error messages to help diagnose issues ## Problem The script was failing silently when the pinned short hash was invalid because: 1. The `curl | tar` pipeline with `&>/dev/null` suppressed all error messages 2. No error checking was performed on the curl command 3. Pipeline exit status only reflected tar, not curl failures This made it very difficult to diagnose why the script was failing when the S3 artifact didn't exist. ## Solution - Split curl and tar into separate operations with individual error checking - Added descriptive error messages that indicate the likely cause (invalid hash) - Removed silent output redirection to allow visibility into failures - Added progress messages during download and extraction Co-authored-by: Claude <noreply@anthropic.com>
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
ludamad
force-pushed
the
merge-train/barretenberg
branch
from
307905b to
1518bd5
Compare
Replace complex and inaccurate "gate estimation" methods with potentially inefficient but simple and accurate method that makes a copy of the circuit then finalizes it to get the true gate count. Such methods should only be used in tests/debugging anyway so the extra copying is not an issue.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: ram ram audit 1 (#17683)
feat: Implement PairingPoints tagging mechanism (#17988)
chore(bb): remove some is_curve checks (#18037)
fix: add proper error handling for invalid short hash in VK test script (#18055)
fix: format.sh
chore: remove gate estimation (#17879)
END_COMMIT_OVERRIDE