chore: cleanup the new IVC integration#17931
Merged
ludamad merged 24 commits intomerge-train/barretenbergfrom Oct 29, 2025
Merged
chore: cleanup the new IVC integration#17931ludamad merged 24 commits intomerge-train/barretenbergfrom
ludamad merged 24 commits intomerge-train/barretenbergfrom
Conversation
ludamad
added a commit
that referenced
this pull request
Oct 28, 2025
…C rename) Resolved conflicts following the principle of preferring our branch's ClientIVC naming: 1. **client_ivc.cpp**: - Kept ClientIVC:: prefix (not SumcheckClientIVC::) - Updated return type to include std::vector<PairingPoints> (from origin/next) 2. **pg_recursion_constraint.test.cpp**: - Deleted file as it was renamed to hypernova_recursion_constraint.test.cpp in our branch 3. **ultra_verifier.cpp**: - Added kernel_return_data assignment from origin/next - Kept updated comment about ClientIVC proof verification All changes maintain the SumcheckClientIVC → ClientIVC rename while incorporating necessary updates from origin/next. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ludamad
force-pushed
the
kb/sumcheck_ivc_cleanup
branch
from
a5ec4a5 to
6ba95ec
Compare
ludamad
added a commit
that referenced
this pull request
Oct 28, 2025
…C rename) Resolved conflicts following the principle of preferring our branch's ClientIVC naming: 1. **client_ivc.cpp**: - Kept ClientIVC:: prefix (not SumcheckClientIVC::) - Updated return type to std::vector<ClientIVC::PairingPoints> from origin/next 2. **pg_recursion_constraint.test.cpp**: - Deleted file as it was renamed to hypernova_recursion_constraint.test.cpp in our branch 3. **ultra_verifier.cpp**: - Added kernel_return_data assignment from origin/next - Updated comment about ClientIVC proof verification All changes maintain the SumcheckClientIVC → ClientIVC rename while incorporating necessary updates from origin/next. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ludamad
force-pushed
the
kb/sumcheck_ivc_cleanup
branch
3 times, most recently
from
cb7bccc to
f2c0ec5
Compare
ludamad
force-pushed
the
kb/sumcheck_ivc_cleanup
branch
from
f2c0ec5 to
3050619
Compare
ludamad
reviewed
Oct 29, 2025
| set -e | ||
| set -euo pipefail | ||
|
|
||
| function format_files { |
Collaborator
There was a problem hiding this comment.
Added by me tired of waiting to format files
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
ludamad
approved these changes
Oct 29, 2025
ludamad
added a commit
that referenced
this pull request
Dec 16, 2025
Co-authored-by: ludamad <domuradical@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.
For audit-related pull requests, please use the audit PR template.