fix: Check slash round lifetime when looking back executable rounds#17652
Merged
PhilWindle merged 1 commit intonextfrom Oct 13, 2025
Merged
fix: Check slash round lifetime when looking back executable rounds#17652PhilWindle merged 1 commit intonextfrom
PhilWindle merged 1 commit intonextfrom
Conversation
In #17245 we changed the slasher client to check for older rounds pending execution, with a config variable that indicates how far to look back. However, the lifetime in rounds in staging ended up being smaller than the lookback, so we were picking rounds no longer valid. This PR checks that we do not look that far back.
PhilWindle
approved these changes
Oct 13, 2025
Collaborator
|
❌ Failed to cherry-pick to |
spalladino
pushed a commit
that referenced
this pull request
Oct 16, 2025
…17652) In #17245 we changed the slasher client to check for older rounds pending execution, with a config variable that indicates how far to look back. However, the lifetime in rounds in staging ended up being smaller than the lookback, so we were picking rounds no longer valid. This PR checks that we do not look that far back.
spalladino
pushed a commit
that referenced
this pull request
Oct 16, 2025
…17652) In #17245 we changed the slasher client to check for older rounds pending execution, with a config variable that indicates how far to look back. However, the lifetime in rounds in staging ended up being smaller than the lookback, so we were picking rounds no longer valid. This PR checks that we do not look that far back.
spalladino
pushed a commit
that referenced
this pull request
Oct 16, 2025
…17652) In #17245 we changed the slasher client to check for older rounds pending execution, with a config variable that indicates how far to look back. However, the lifetime in rounds in staging ended up being smaller than the lookback, so we were picking rounds no longer valid. This PR checks that we do not look that far back.
spalladino
pushed a commit
that referenced
this pull request
Oct 17, 2025
…17652) In #17245 we changed the slasher client to check for older rounds pending execution, with a config variable that indicates how far to look back. However, the lifetime in rounds in staging ended up being smaller than the lookback, so we were picking rounds no longer valid. This PR checks that we do not look that far back.
spalladino
pushed a commit
that referenced
this pull request
Oct 17, 2025
…17652) In #17245 we changed the slasher client to check for older rounds pending execution, with a config variable that indicates how far to look back. However, the lifetime in rounds in staging ended up being smaller than the lookback, so we were picking rounds no longer valid. This PR checks that we do not look that far back.
spalladino
added a commit
that referenced
this pull request
Oct 17, 2025
…17652) (#17749) Backport of #17652 In #17245 we changed the slasher client to check for older rounds pending execution, with a config variable that indicates how far to look back. However, the lifetime in rounds in staging ended up being smaller than the lookback, so we were picking rounds no longer valid. This PR checks that we do not look that far back. Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com>
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #17245 we changed the slasher client to check for older rounds pending execution, with a config variable that indicates how far to look back.
However, the lifetime in rounds in staging ended up being smaller than the lookback, so we were picking rounds no longer valid.
This PR checks that we do not look that far back.