Conversation
ludamad
reviewed
Oct 6, 2025
| const out = gunzipSync(data); | ||
| return out; | ||
| } catch { | ||
| // Fall through to return original if decompression fails |
Collaborator
There was a problem hiding this comment.
Hey sorry for drive-by review - if we have a truncated gzip packet this may be a bit confusing as we'll just try it uncompressed, seems maybe better to just hard error?
Member
Author
There was a problem hiding this comment.
yeah I think that makes sense. But only if isGzipMagic is true I think as headers can lie.updating
Collaborator
There was a problem hiding this comment.
Yeah if we don't have the magic numbers arguably we should never try then (if we want to allow lying)
spypsy
force-pushed
the
spy/r2-v2-backport
branch
from
890901a to
e793a59
Compare
AztecBot
force-pushed
the
spy/r2-v2-backport
branch
from
e793a59 to
49a649f
Compare
PhilWindle
approved these changes
Oct 6, 2025
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes A-23
Backporting:
#17115
#17434
#17511