Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
056d632 to
d48189b
Compare
spalladino
left a comment
There was a problem hiding this comment.
Looks good!
On bigint-buffer, I see we're using it only via the chainsafe discv5 and enr packages, but it seems they removed this dependency earlier this year. Maybe we can update to those versions?
As for private-ip, it's only pulled in from kad-dht, which removed it in early 2024. Perhaps we can update it as well? But more interestingly, it seems we're importing the package but not using it for anything, unless it has side effects? So maybe we could just remove it?
1ce7a6e to
1b9a2d5
Compare
Good catch @spalladino, sorry for missing this 🤦
|
This PR updates most of the `yarn-project` dependabot alerted deps. ### On resolutions I have tried to update all deps "properly", using `resolutions` as a fallback. This is when we depend on D, which has outdated D' for which Dependabot complains, and D doesn't have a newer version. An example of this is [docosaurus-plugin-ideal-image](https://github.com/facebook/docusaurus/blob/main/packages/docusaurus-plugin-ideal-image/package.json) > sharp (outdated) > tar-fs (outdated) - meaning that `docusaurus-plugin-ideal-image` imports an outdated version of `sharp`, which in turn imports an outdated version of `tar-fs`, so we have to force this fix via `resolutions` ### Not updated deps I could not update two dependencies because the author has not fixed the bug and published an update: 1. [bigint-buffer](https://github.com/no2chem/bigint-buffer/releases) 2. [private-ip](https://github.com/frenchbread/private-ip/releases) Both of these are transitive deps, further complicating the update.
1b9a2d5 to
64b2bc4
Compare
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
|
@spalladino, updating Upgrading said packages ( |
|
Damn. WDYT about using yarn patch to manually remove all bigint-buffer usage from the packages then? The other option is to just fork, since I doubt libp2p would accept a patch with that change for such an older version (though we could try). |
I'll attack this tomorrow, atm. forking seems cleaner :) |
This PR updates most of the
yarn-projectdependabot alerted deps.On resolutions
I have tried to update all deps "properly", using
resolutionsas a fallback. This is when we depend on D, which has outdated D' for which Dependabot complains, and D doesn't have a newer version.An example of this is docosaurus-plugin-ideal-image > sharp (outdated) > tar-fs (outdated) - meaning that
docusaurus-plugin-ideal-imageimports an outdated version ofsharp, which in turn imports an outdated version oftar-fs, so we have to force this fix viaresolutionsNot updated deps
I could not update two dependencies because the author has not fixed the bug and published an update:
Both of these are transitive deps, further complicating the update.