Skip to content

chore: dependabot deps#17418

Merged
AztecBot merged 1 commit intonextfrom
chore/dependabot-deps
Oct 1, 2025
Merged

chore: dependabot deps#17418
AztecBot merged 1 commit intonextfrom
chore/dependabot-deps

Conversation

@mralj
Copy link
Contributor

@mralj mralj commented Oct 1, 2025

This PR updates most of the yarn-project dependabot alerted deps.

On resolutions

I have tried to update all deps "properly", using resolutions as a fallback. This is when we depend on D, which has outdated D' for which Dependabot complains, and D doesn't have a newer version.

An example of this is docosaurus-plugin-ideal-image > sharp (outdated) > tar-fs (outdated) - meaning that docusaurus-plugin-ideal-image imports an outdated version of sharp, which in turn imports an outdated version of tar-fs, so we have to force this fix via resolutions

Not updated deps

I could not update two dependencies because the author has not fixed the bug and published an update:

  1. bigint-buffer
  2. private-ip

Both of these are transitive deps, further complicating the update.

@socket-security
Copy link

socket-security bot commented Oct 1, 2025

@mralj mralj self-assigned this Oct 1, 2025
@mralj mralj requested review from PhilWindle and spalladino October 1, 2025 10:20
@mralj mralj force-pushed the chore/dependabot-deps branch from 056d632 to d48189b Compare October 1, 2025 11:56
Copy link
Contributor

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

On bigint-buffer, I see we're using it only via the chainsafe discv5 and enr packages, but it seems they removed this dependency earlier this year. Maybe we can update to those versions?

As for private-ip, it's only pulled in from kad-dht, which removed it in early 2024. Perhaps we can update it as well? But more interestingly, it seems we're importing the package but not using it for anything, unless it has side effects? So maybe we could just remove it?

@mralj
Copy link
Contributor Author

mralj commented Oct 1, 2025

Looks good!

On bigint-buffer, I see we're using it only via the chainsafe discv5 and enr packages, but it seems they removed this dependency earlier this year. Maybe we can update to those versions?

As for private-ip, it's only pulled in from kad-dht, which removed it in early 2024. Perhaps we can update it as well? But more interestingly, it seems we're importing the package but not using it for anything, unless it has side effects? So maybe we could just remove it?

Good catch @spalladino, sorry for missing this 🤦

  1. I have removed kad-dht
  2. I will update discv5 & enr in a separate PR, as the update yielded ~40 TS errors, so I think separate PR for this one is bettter :)

This PR updates most of the `yarn-project` dependabot alerted deps.

### On resolutions
I have tried to update all deps "properly", using `resolutions` as a fallback. This is when we depend on D, which has outdated D' for which Dependabot complains, and D doesn't have a newer version.

An example of this is [docosaurus-plugin-ideal-image](https://github.com/facebook/docusaurus/blob/main/packages/docusaurus-plugin-ideal-image/package.json) > sharp (outdated) > tar-fs (outdated) - meaning that `docusaurus-plugin-ideal-image` imports an outdated version of `sharp`, which in turn imports an outdated version of `tar-fs`, so we have to force this fix via `resolutions`

### Not updated deps

I could not update two dependencies because the author has not fixed the bug and published an update:
1. [bigint-buffer](https://github.com/no2chem/bigint-buffer/releases)
2. [private-ip](https://github.com/frenchbread/private-ip/releases)

Both of these are transitive deps, further complicating the update.
@AztecBot AztecBot force-pushed the chore/dependabot-deps branch from 1b9a2d5 to 64b2bc4 Compare October 1, 2025 14:10
@AztecBot AztecBot enabled auto-merge October 1, 2025 14:10
@AztecBot AztecBot added this pull request to the merge queue Oct 1, 2025
Merged via the queue into next with commit 295103a Oct 1, 2025
14 checks passed
@AztecBot AztecBot deleted the chore/dependabot-deps branch October 1, 2025 14:55
@AztecBot
Copy link
Collaborator

AztecBot commented Oct 1, 2025

💔 All backports failed

Status Branch Result
v2 Backport failed because of merge conflicts

You might need to backport the following PRs to v2:
- chore: Delete contract addresses from chain l2 config (#17417)
- Delete contract addresses from chain l2 config

Manual backport

To create the backport manually run:

backport --pr 17418

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@mralj
Copy link
Contributor Author

mralj commented Oct 1, 2025

@spalladino, updating discv5/enr seems to be a no-go at the moment.
The issue is that both rely on libp2p types with breaking changes (link), which we import as well.

Upgrading said packages (libp2p/interface/libp2p/peer-id) breaks a lot of code, and following this rabbit hole a bit it looks like it would imply upgrading the libp2p itself 🥲

@spalladino
Copy link
Contributor

Damn. WDYT about using yarn patch to manually remove all bigint-buffer usage from the packages then? The other option is to just fork, since I doubt libp2p would accept a patch with that change for such an older version (though we could try).

@mralj
Copy link
Contributor Author

mralj commented Oct 1, 2025

Damn. WDYT about using yarn patch to manually remove all bigint-buffer usage from the packages then? The other option is to just fork, since I doubt libp2p would accept a patch with that change for such an older version (though we could try).

I'll attack this tomorrow, atm. forking seems cleaner :)

AztecBot pushed a commit that referenced this pull request Oct 2, 2025
AztecBot added a commit that referenced this pull request Oct 2, 2025
ludamad pushed a commit that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants