feat: associating tagging index with tx hash#17415
Closed
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3788ddb to
309fc54
Compare
fa15eaa to
d5e3676
Compare
171b7ba to
dfe7b5c
Compare
Base automatically changed from
09-29-refactor_cleaning_up_tagging_oracles
to
next
October 1, 2025 08:26
d5e3676 to
1942370
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In this PR I implement the following:
highest_tracked_indexis found over all known indexes, even over dropped transactions BUT its maximum value is capped to LAST_FINALIZED_INDEX + WINDOW_LENGTH. This means that if too many txs get dropped we would link the new tx with the dropped one. Given that this is quite unlikely to happen if we set the WINDOW_LENGTH large enough I think this is fine.