Skip to content

feat: associating tagging index with tx hash#17415

Closed
benesjan wants to merge 1 commit intonextfrom
10-01-feat_associating_tagging_index_with_tx_hash
Closed

feat: associating tagging index with tx hash#17415
benesjan wants to merge 1 commit intonextfrom
10-01-feat_associating_tagging_index_with_tx_hash

Conversation

@benesjan
Copy link
Contributor

@benesjan benesjan commented Oct 1, 2025

In this PR I implement the following:

  • when transaction witness generation starts (beginning of pxe.proveTx) we prune indexes without tx hash to get rid of the mess caused by simulations (this should fix this issue),
  • once the tx construction is finished (end of pxe.proveTx) we associate the new indexes with the given tx hash and mark the tx hash with PENDING status in the TaggingDataProvider,
  • the synchronizer then loads all these tx hashes upon sync, requests the node for status and updates the statuses of these indexes (and reverts the statuses on reorgs),
  • the possible statuses are: PENDING, DROPPED, FINALIZED (note that whether the tx reverted is irrelevant for indexes)
  • the call to privateGetNextAppTagAsSender oracle function in a tx returns tag that corresponds to (highest_tracked_index + 1),
  • the highest_tracked_index is found over all known indexes, even over dropped transactions BUT its maximum value is capped to LAST_FINALIZED_INDEX + WINDOW_LENGTH. This means that if too many txs get dropped we would link the new tx with the dropped one. Given that this is quite unlikely to happen if we set the WINDOW_LENGTH large enough I think this is fine.
  • we prune all the metadata about indexes that are before the LATEST_FINALIZED_INDEX to save db space.

Copy link
Contributor Author

benesjan commented Oct 1, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@benesjan benesjan force-pushed the 09-29-refactor_cleaning_up_tagging_oracles branch from 3788ddb to 309fc54 Compare October 1, 2025 07:01
@benesjan benesjan force-pushed the 10-01-feat_associating_tagging_index_with_tx_hash branch 2 times, most recently from fa15eaa to d5e3676 Compare October 1, 2025 07:16
@AztecBot AztecBot force-pushed the 09-29-refactor_cleaning_up_tagging_oracles branch from 171b7ba to dfe7b5c Compare October 1, 2025 07:48
Base automatically changed from 09-29-refactor_cleaning_up_tagging_oracles to next October 1, 2025 08:26
@benesjan benesjan force-pushed the 10-01-feat_associating_tagging_index_with_tx_hash branch from d5e3676 to 1942370 Compare October 1, 2025 14:02
@benesjan benesjan closed this Oct 2, 2025
@benesjan benesjan deleted the 10-01-feat_associating_tagging_index_with_tx_hash branch October 2, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] account contracts get broken with "Failed to get a note 'self.is_some()'"

1 participant