feat(noir): use #[aztec(private)] and #[aztec(public) attributes

[Maddiaa0]

Overview

Now that noir-lang/noir#2403 has been merged into noir and released under the aztec tag. This PR now builds!

This cleans up the syntax for noir programs, making them less verbose and easier to get started with.
For example what originally was:

    fn mint(
        inputs: PrivateContextInputs,
        amount: Field, 
        owner: Field
    ) -> distinct pub abi::PrivateCircuitPublicInputs {
        let storage = Storage::init();
        let mut context = PrivateContext::new(inputs, abi::hash_args([amount, owner]));

        // Insert new note to a set of user notes and emit the newly created encrypted note preimage via oracle call.
        let owner_balance = storage.balances.at(owner);
        send_note(&mut context, owner_balance, amount, owner);
        emit_unencrypted_log(&mut context, "Coins minted");

        // Return private circuit public inputs. All private functions need to return this as it is part of the input of the private kernel..
        context.finish()
    }

can instead be written as:

   #[aztec(private)]
    fn mint(
        amount: Field, 
        owner: Field
    )  {
        let storage = Storage::init();

        // Insert new note to a set of user notes and emit the newly created encrypted note preimage via oracle call.
        let owner_balance = storage.balances.at(owner);
        send_note(&mut context, owner_balance, amount, owner);
        emit_unencrypted_log(&mut context, "Coins minted");
    }

[ludamad]

Where can I find the impl of these?

[Maddiaa0]

Where can I find the impl of these?

I have just created a draft pr over here: there is still a bit of work to be done! noir-lang/noir#2403

[sirasistant]

Incredible cleanup, great job! Some manual calls to new() are still present though :D

[sirasistant]

Nice! 🎉

[sirasistant]

Thanks a lot! Only some nits regarding TODOs

[sirasistant]

I think this TODO is already solved (?)

[sirasistant]

Same with this one

[sirasistant]

Not sure what this TODO means