Merged
Conversation
alexghr
approved these changes
Sep 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
As part of #17273 I had added a cleanup to the gossip network test to delete data dirs for the prover. However, the `stop` method on the prover failed to await for all operations, so when the test finished successfully, it would still try to use the db (in particular, it seems to be for the proving broker database `getEpochDatabase`) and abort with a core dump. This reverts the folder cleanup.
spalladino
force-pushed
the
palla/deflake-gossip-test
branch
from
c19590d to
f823313
Compare
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #17273 I had added a cleanup to the gossip network test to delete data dirs for the prover. However, the
stopmethod on the prover failed to await for all operations, so when the test finished successfully, it would still try to use the db (in particular, it seems to be for the proving broker databasegetEpochDatabase) and abort with a core dump.This reverts the folder cleanup.