Skip to content

fix(bb): oversight that disabled batch commits #17278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 2 commits into from
Sep 25, 2025
Merged

fix(bb): oversight that disabled batch commits #17278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d636040
fix: oversight that disabled batch commits
ludamad Sep 24, 2025
2658fcf
Clean up comments in commitment_key.hpp
ludamad Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions barretenberg/cpp/src/barretenberg/commitment_schemes/commitment_key.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,16 +123,13 @@ template <class Curve> class CommitmentKey {
// First batch, create the commitments vector
std::vector<Commitment> commitments;

max_batch_size = 1;
for (size_t i = 0; i < polynomials.size();) {
// Note: have to be careful how we compute this to not overlow e.g. max_batch_size + 1 would
size_t batch_size = std::min(max_batch_size, polynomials.size() - i);
size_t batch_end = i + batch_size;

// Prepare spans for batch MSM
std::vector<std::span<const G1>> points_spans;
// Note, we need to const_cast unfortunately as pippenger takes non-const spans
// as it converts back and forth from montgomery form
std::vector<std::span<Fr>> scalar_spans;

for (auto& polynomial : polynomials.subspan(i, batch_end - i)) {
Expand Down
Loading