Skip to content

chore(backport-to-v2): chore(avm)!: Fix a misleading log in recursive verifier related to public input (#17184) #17218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeanmon merged 1 commit into from
Sep 23, 2025
Merged

chore(backport-to-v2): chore(avm)!: Fix a misleading log in recursive verifier related to public input (#17184) #17218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions barretenberg/cpp/src/barretenberg/vm2/constraining/recursion/recursive_verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,8 @@ AvmRecursiveVerifier::PairingPoints AvmRecursiveVerifier::verify_proof(
// public_input_evaluation.assert_equal(claimed_evaluations[i]
for (size_t i = 0; i < AVM_NUM_PUBLIC_INPUT_COLUMNS; i++) {
FF public_input_evaluation = evaluate_public_input_column(public_inputs[i], output.challenge);
vinfo("public_input_evaluation failed, public inputs col ", i);
pi_validation.must_imply(public_input_evaluation == claimed_evaluations[i], "public_input_evaluation failed");
pi_validation.must_imply(public_input_evaluation == claimed_evaluations[i],
format("public_input_evaluation failed at column ", i));
}

// Execute Shplemini rounds.
Expand All @@ -184,6 +184,11 @@ AvmRecursiveVerifier::PairingPoints AvmRecursiveVerifier::verify_proof(
padding_indicator_array, claim_batcher, output.challenge, Commitment::one(&builder), transcript);

auto pairing_points = PCS::reduce_verify_batch_opening_claim(opening_claim, transcript);

if (builder.failed()) {
info("AVM Recursive verifier builder failed with error: ", builder.err());
}

return pairing_points;
}

Expand Down
Loading