feat: Allow vetoer to disable slasher temporarily#16971
Merged
spalladino merged 1 commit intonextfrom Sep 12, 2025
Merged
Conversation
spalladino
requested review from
LHerskind,
Maddiaa0 and
just-mitch
as code owners
spalladino
changed the title
spalladino
force-pushed
the
palla/disable-slashing
branch
2 times, most recently
from
e12bc68 to
a460f66
Compare
Contributor
|
🔥 |
LHerskind
approved these changes
Sep 12, 2025
l1-contracts/test/governance/scenario/slashing/TallySlashing.t.sol
Outdated
Show resolved
Hide resolved
l1-contracts/test/governance/scenario/slashing/TallySlashing.t.sol
Outdated
Show resolved
Hide resolved
Allows the vetoer to disable slashing altogether temporarily. This allows the vetoer to stop all slashes if a bug is detected that continuously triggers slashes that are not valid, so the vetoer does not need to continuously vetoed every individual slash until the issue is solved.
spalladino
force-pushed
the
palla/disable-slashing
branch
from
a460f66 to
cf3afa8
Compare
spalladino
added a commit
that referenced
this pull request
Sep 12, 2025
Allows the vetoer to disable slashing altogether temporarily. This allows the vetoer to stop all slashes if a bug is detected that continuously triggers slashes that are not valid, so the vetoer does not need to continuously vetoed every individual slash until the issue is solved.
PhilWindle
pushed a commit
that referenced
this pull request
Sep 30, 2025
Plenty contract PR's have been implemented since the cut of V2. I'm taking a look into them to figure out if we need all of them. And can make a potential monster cherry pick. ```bash git --no-pager log --oneline v2..next -- "l1-contracts/" 44e3f64 fix: tmnt 412 70f004d fix: tmnt 405, 411, 413, 414, 418, 419, 421, 425 b02160b fix: Fix the hash to point function randomness 5cd8f41 fix: gas boundary and removal of isOnCurve a310dd9 chore: fix misc issues for clarity 46e3dd7 chore: update gse deposit natspec (#17247) 7a12a96 chore: add comment to addRollup 3887ea2 feat: queue flushing update a3e23b9 Checkpoint circuits. 545904b (origin/saleel/zkpassport-update) chore: add validity period check on zkpassport (#17054) 10e4df4 chore: update zkpassport version (#17044) ffd05ca (tag: v3.0.0-nightly.20250915) chore: update coin issuer rate (#16985) ac300f4 chore: Fix governance vote test (#17023) e7136e6 chore: Fix governance vote test 4502f07 fix: unbounded lock delay (#16951) ba13aa6 (origin/gh-readonly-queue/next/pr-16971-0fcfb7625e38cd58b602a8b09b1f6b48cfbc693a) feat: Allow vetoer to disable slasher temporarily (#16971) cf3afa8 (origin/palla/disable-slashing) feat: Allow vetoer to disable slasher 0fcfb76 (origin/gh-readonly-queue/next/pr-16950-d6cff17e9a10e8305925d1cd1020c30a0e3eb6bf) fix: error prefix (#16950) 50b0c1d chore: reject gov deposit into gov (#16917) 1175713 chore: update coin issuer rate 45e3bdb fix: unbounded lock delay 93976d6 fix: error prefix 95c296f chore: reject gov deposit into gov b208c8e (origin/09-11-refactor_fixing_offchain_onchain_naming) refactor: fixing offchain/onchain naming e87438b chore: minor misc solidity changes a29ccaa fix: align timestamps for sample values 31331e2 (origin/gh-readonly-queue/next/pr-16934-7188c46c1b4a151b77c3ec5a4a8817a19b74927c) chore: Fix slash veto demo flake (#16934) b59e100 (origin/palla/try-fix-veto-demo-flake) chore: Try fix slash veto demo flake 2695b7b fix: never use cache in `verifyProposer` 9193dfb chore: add few extra checks f85a17f feat: local ejection threshold 97928de (origin/gh-readonly-queue/next/pr-16753-5475f5b912ae31492bb93c783f08ca6f7d38b2c6) fix: proposer sign digest of attestations (#16753) 87038a3 chore: silence unhelpful forge lints (#16809) 1305503 (origin/tf/silence-forge-lints) chore: silence unhelpful forge lints 2f71e44 fix: proposer sign digest of attestations f4b78b5 Merge branch 'next' into merge-train/avm ``` I'll be cherry picking these with a few exceptions, namely: ```bash a3e23b9 Checkpoint circuits. b208c8e (origin/09-11-refactor_fixing_offchain_onchain_naming) refactor: fixing offchain/onchain naming ``` as these are touching so so many files. a3e23b9 deals with the checkpoint building, which we don't really need for ignition. And the other is just spelling in the comments. And to be frank, I'm not feeling all that great about doing a 125 file commit backport just for spelling in the comments --------- Co-authored-by: TomAFrench <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Santiago Palladino <santiago@aztec-labs.com> Co-authored-by: saleel <saleel@saleel.xyz>
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the vetoer to disable slashing altogether temporarily. This allows the vetoer to stop all slashes if a bug is detected that continuously triggers slashes that are not valid, so the vetoer does not need to continuously vetoed every individual slash until the issue is solved.
Slashing is disabled for
slashingDisableDuration(immutable, set during deployment, defaults to 5 days) and then automatically resumed. Vetoer can extend the disabled period at any time, and can also resume the slashing.