Skip to content

fix(bb): darwin build #16957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 1 commit into from
Sep 11, 2025
Merged

fix(bb): darwin build #16957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions barretenberg/cpp/src/barretenberg/common/bb_bench.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ void AggregateEntry::add_thread_time_sample(const TimeAndCount& stats)
// Account for aggregate time and count
time += stats.time;
count += stats.count;
time_max = std::max(stats.time, time_max);
time_max = std::max(static_cast<size_t>(stats.time), time_max);
// Use Welford's method to be able to track the variance
num_threads++;
double delta = static_cast<double>(stats.time) - time_mean;
Expand Down Expand Up @@ -526,7 +526,7 @@ void GlobalBenchStatsContainer::print_aggregate_counts_hierarchical(std::ostream
uint64_t total_time = 0;
for (const auto& [_, parent_map] : aggregated) {
if (auto it = parent_map.find(""); it != parent_map.end()) {
total_time = std::max(total_time, it->second.time_max);
total_time = std::max(static_cast<size_t>(total_time), it->second.time_max);
}
}

Expand Down
Loading