Skip to content

fix: unbounded lock delay #16951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LHerskind merged 1 commit into from
Sep 12, 2025
Merged

fix: unbounded lock delay #16951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions l1-contracts/src/governance/libraries/ConfigurationLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ library ConfigurationLib {
uint256 internal constant LOCK_AMOUNT_UPPER = type(uint96).max; // Maximum for compressed storage (uint96)

Timestamp internal constant TIME_LOWER = Timestamp.wrap(60);
Timestamp internal constant TIME_UPPER = Timestamp.wrap(30 * 24 * 3600);
Timestamp internal constant TIME_UPPER = Timestamp.wrap(90 * 24 * 3600);

/**
* @notice The delay after which a withdrawal can be finalized.
Expand Down Expand Up @@ -66,12 +66,13 @@ library ConfigurationLib {
);

// Beyond checking the bounds like this, it might be useful to ensure that the value is larger than the withdrawal
// delay
// this, can be useful if one want to ensure that the "locker" cannot himself vote in the proposal, but as it is
// unclear
// if this is a useful property, it is not enforced.
// delay. this, can be useful if one want to ensure that the "locker" cannot himself vote in the proposal, but as
// it is unclear if this is a useful property, it is not enforced.
require(_self.proposeConfig.lockDelay >= TIME_LOWER, Errors.Governance__ConfigurationLib__TimeTooSmall("LockDelay"));
require(_self.proposeConfig.lockDelay <= TIME_UPPER, Errors.Governance__ConfigurationLib__TimeTooBig("LockDelay"));
require(
_self.proposeConfig.lockDelay <= Timestamp.wrap(type(uint32).max),
Errors.Governance__ConfigurationLib__TimeTooBig("LockDelay")
);

require(_self.votingDelay >= TIME_LOWER, Errors.Governance__ConfigurationLib__TimeTooSmall("VotingDelay"));
require(_self.votingDelay <= TIME_UPPER, Errors.Governance__ConfigurationLib__TimeTooBig("VotingDelay"));
Expand Down
3 changes: 1 addition & 2 deletions l1-contracts/test/governance/governance/updateConfiguration.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ contract UpdateConfigurationTest is GovernanceBase {
vm.prank(address(governance));
governance.updateConfiguration(config);

config.proposeConfig.lockDelay =
Timestamp.wrap(bound(_val, Timestamp.unwrap(ConfigurationLib.TIME_UPPER) + 1, type(uint256).max));
config.proposeConfig.lockDelay = Timestamp.wrap(uint256(type(uint32).max) + 1);
vm.expectRevert(abi.encodeWithSelector(Errors.Governance__ConfigurationLib__TimeTooBig.selector, "LockDelay"));
vm.prank(address(governance));
governance.updateConfiguration(config);
Expand Down
Loading