feat: moving event emission functions onto the EventInterface trait#16762
Closed
feat: moving event emission functions onto the EventInterface trait#16762
EventInterface trait#16762Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
changed the title
EventInterface trait
benesjan
commented
Sep 4, 2025
| @@ -46,15 +54,15 @@ comptime fn register_event_selector(event_selector: Field, event_name: Quoted) { | |||
| } | |||
|
|
|||
| pub comptime fn event(s: TypeDefinition) -> Quoted { | |||
Contributor
Author
There was a problem hiding this comment.
Did the change in this function as now it feels more logical given that we have the super trait and EventInterface is kinda like dependent on Serilize.
Contributor
Author
|
No longer planned because of introduction of self in contracts #17884 |
benesjan
deleted the
09-04-feat_moving_event_emission_functions_onto_the_eventinterface_trait
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at the above.
Corrently blocked by noir-lang/noir#9732