fix(nargo): don't thread-bomb unnecessarily#16594
Closed
ludamad wants to merge 1 commit intomerge-train/barretenbergfrom
Closed
fix(nargo): don't thread-bomb unnecessarily#16594ludamad wants to merge 1 commit intomerge-train/barretenbergfrom
ludamad wants to merge 1 commit intomerge-train/barretenbergfrom
Conversation
noir repo PR noir-lang/noir#9643 Previously, setting RAYON_NUM_THREADS was the workaround for running many nargos in parallel. However, to be able to run on a very large number of core machine like aztec's shared "mainframe" instance, there was easy low-hanging fruit. This removes all the cases where threads allocated could have been >> threads used.
ledwards2225
approved these changes
Aug 26, 2025
Member
|
Can we just update the pinned commit once the other PR is merged? This just immediately creates extra work in the sync to remove this patch. |
Collaborator
Author
|
Sure! I wanted to decouple the process, but whatever is easiest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noir repo PR noir-lang/noir#9643, this is just getting in ahead of the next sync (unless noir team advises otherwise)
Previously, setting RAYON_NUM_THREADS was the workaround for running many nargos in parallel. However, to be able to run on a very large number of core machine like aztec's shared "mainframe" instance, there was easy low-hanging fruit.
This removes all the cases where threads allocated could have been >> threads used.